Added info about editing migrations

Activity

FEOLMIS-3541 5

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 29m 2 Sure, I'm still working on that.
    Reviewer - Complete 6m 2 Please add this to template service: https://github.com/O...
    Reviewer - Complete 18m 1 Hopefully comments do not modify the checksum, but yes - ...
    Reviewer - 0% reviewed      
    Total   53m 5  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    From what I know if a migration that has been applied to a database and it wa...

    From what I know if a migration that has been applied to a database and it was changed the flyway will throw an exception (about incorrect code or something like that). Could we verify that those comments will not break anything?

    Sebastian Brudziński

    Hopefully comments do not modify the checksum, but yes - worth checking

    Hopefully comments do not modify the checksum, but yes - worth checking

    Klaudia Pałkowska

    Unfortunately, it does so I reverted the changes and updated task for generat...

    Unfortunately, it does so I reverted the changes and updated task for generating new migration.

    Łukasz Lewczyński

    Please add this to template service: https://github.com/OpenLMIS/openlmis-tem...

    Klaudia Pałkowska

    Sure, I'm still working on that.

    Sure, I'm still working on that.

    /src/.../migration/20170214123504310__initial_schema.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170214123932959__initial_bootstrap_data.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170404125519633__alter_auth_users_email_nullable.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170627082106947__removed_initial_clients_resourceids.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170711211208618__index_username_of_auth_users.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170724084322325__remove_auth_role_from_user.sql Changed
    Open in IDE #permalink
    /src/.../migration/20171215105642158__added_api_keys.sql Changed
    Open in IDE #permalink
    /src/.../migration/20171219124429037__unique_username_ignore_case.sql Changed
    Open in IDE #permalink
    /src/.../migration/20180320172415321__connect_api_keys_with_client.sql Changed
    Open in IDE #permalink
    /src/.../migration/20180613120215847__remove_referencedatauserid_from_user.sql Changed
    Open in IDE #permalink
    /build.gradle Changed
    Open in IDE #permalink
    /src/.../migration/20170703115656512__initial_schema.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170720141040004__create_table_cce_inventory.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170724142909374__add_primary_keys.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170801113005321__inventory_changed_column_name.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170804085432312__add_serial_number_and_reference_name.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170807102040174__add_archived_column_to_cce_catalog.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170810170921962__add_decommission_date_and_rtm_and_remove_serial_number.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170811072301442__remove_unique_id.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170811110808422__fix_cce_db_issues.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170818132535841__remove_barcode_from_inventory_item.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170821083234152__remove_requiresAttention_from_inventory_item.sql Changed
    Open in IDE #permalink
    /src/.../migration/20170913173534345__add_unique_constraints_to_catalog_items.sql Changed
    Open in IDE #permalink
    /src/.../migration/20171114101548905__add_index_for_facilityId_and_programId_fields_in_inventory_item.sql Changed
    Open in IDE #permalink
    /src/.../migration/20171114110706846__add_index_for_catalogItemId_in_inventory_item.sql Changed
    Open in IDE #permalink
    /src/.../migration/20171120102801224__add_columns_to_inventoryitem.sql Changed
    Open in IDE #permalink
    /src/.../migration/20171128174204892__drop_columns_from_inventoryitem.sql Changed
    Open in IDE #permalink
    /src/.../migration/20180216055219230__create_cce_alerts.sql Changed
    Open in IDE #permalink
    /build.gradle Changed
    /build.gradle Changed
    /build.gradle Changed
    Open in IDE #permalink
    /build.gradle Changed
    /build.gradle Changed
    /build.gradle Changed
    /build.gradle Changed
    Open in IDE #permalink
    /build.gradle Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against