OLMIS-5468: Fixed migration tests

Activity

FEOLMIS-3392 11

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 33m 7 Oops, done.
    Reviewer - Complete 1m    
    Reviewer - Complete 22m 4 LGTM, thanks for taking care of that!
    Reviewer - 36% reviewed 6m    
    Reviewer - 36% reviewed 1m    
    Total   1h 3m 11  
    #permalink

    Objectives

    • Added service logs
    • Added --no-recreate to disable recreating database container
    • Fixed setting spring profiles

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Sebastian Brudziński

    Thanks for this, Klaudia! Adding a short comment to the modified lines explai...

    Thanks for this, Klaudia! Adding a short comment to the modified lines explaining what was the problem and how that change fixes it would help me understand the impact. Could you do that if it's not too much of a trouble?

    Klaudia Pałkowska

    Sure, done.

    Sure, done.

    Sebastian Brudziński

    LGTM, thanks for taking care of that!

    LGTM, thanks for taking care of that!

    /config/log/logback.xml Changed 4
    /run-tests.sh Changed 4

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against