FEOLMIS-3360 OLMIS-5415: Disabled edit of some fields for externally managed facilities

closed on 10 Oct 18

Author

Reviewers

OLMIS-5415: Disabled edit of some fields for externally managed facilities

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 15

openlmis-cce-ui 0
- Folder src 0
  - Folder cce-edit-inventory-item 0
    - File cce-edit-inventory-item.routes.spec.js 0 Remove
  - Folder cce-inventory-item 0
    - File facility-program-inventory-item-data-builder.spec.js 0 Remove
openlmis-referencedata-ui 0
- Folder src 0
  - Folder admin-facility-view 0
    - File admin-facility-view.routes.js 0 Remove
    - File facility-information.html 0 Remove
    - File facility-view.controller.js 0 Remove
    - File facility-view.controller.spec.js 0 Remove
  - Folder referencedata-facility 0
    - File facility-data-builder.spec.js 0 Remove
    - File facility-repository.js 0 Remove
    - File facility-repository.spec.js 0 Remove
    - File facility-resource.js 2 Remove
    - File facility-resource.spec.js 0 Remove
    - File facility.js 4 Remove
    - File facility.spec.js 0 Remove
- File CHANGELOG.md 0 Remove
openlmis-stockmanagement-ui 0
- Folder src/stock-program-util 0
  - File current-user-home-facility.service.spec.js 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Nikodem Graczewski	Author	15m	2	We want to make sure that both boolean true and String 't...
Łukasz Lewczyński	Reviewer - Complete	1m
Klaudia Pałkowska	Reviewer - 0% reviewed	11m	1	Why do we map boolean to String?
Mateusz Kwiatkowski	Reviewer - Complete	26m	3	and why this is not a new String()?
Total		55m	6

Linked issues
- OLMIS-5415

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-3360

OLMIS-5415: Disabled edit of some fields for externally managed facilities

FEOLMIS-3360 6

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-5415: Disabled edit of some fields for externally managed facilities

FEOLMIS-3360 6

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time