OLMIS-3696: Added dependency locking

Activity

FEOLMIS-3341 10

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 30m 5 What really is important are the changes in the dev-ui re...
    Reviewer - Complete 8m 1 missing changelogs?
    Reviewer - Complete 7m 3 I don't think we need to specifically say we've increased...
    Reviewer - Complete 4m 1 These changes are virtually impossible to review in-depth.
    Total   49m 10  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    missing changelogs?

    missing changelogs?

    Mateusz Kwiatkowski

    Do we need any documentation? Something needs to be changed in release process?

    Do we need any documentation? Something needs to be changed in release process?

    Nikodem Graczewski

    Not really, the release process stays the same. The only difference is that a...

    Not really, the release process stays the same. The only difference is that at some point we will have to update those dependencies so they don't go outdated.

    Nikodem Graczewski

    dev-ui version update has a separate review - FEOLMIS-3344.

    dev-ui version update has a separate review - FEOLMIS-3344.

    Chongsun Ahn

    These changes are virtually impossible to review in-depth.

    These changes are virtually impossible to review in-depth.

    Nikodem Graczewski

    What really is important are the changes in the dev-ui repository and package...

    What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. The change we're introducing here is locking dev-ui dependencies, which are no longer fetched to the node_modules in the root directory, but instead, are fetched into node_modules/dev-ui/node_modules. What we're doing is moving them to the node_modules directory so they are available to the module that is relying on dev-ui, lack of them there would break the build process because of missing dependencies. For yarn.lock we're basically copying the one generated in the .tmp directory, which is where we're firing yarn up during the build process. If you have any concern, please let me know.

    /tasks/yarn.js Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    Open in IDE #permalink
    /Dockerfile Changed
    Open in IDE #permalink
    /build.sh Changed
    Open in IDE #permalink
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package-lock.json Deleted
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /sonar.sh Changed
    Open in IDE #permalink
    /.npmrc Added
    Open in IDE #permalink
    /CHANGELOG.md Changed 2
    Open in IDE #permalink
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /yarn.lock Added
    Open in IDE #permalink
    /.npmrc Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    Open in IDE #permalink
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /yarn.lock Added
    Open in IDE #permalink
    /.npmrc Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /yarn.lock Added
    Open in IDE #permalink
    /.npmrc Added
    Open in IDE #permalink
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /yarn.lock Added
    Open in IDE #permalink
    /CHANGELOG.md Changed 2
    /.npmrc Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    Open in IDE #permalink
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /yarn.lock Added
    Open in IDE #permalink
    /.npmrc Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /yarn.lock Added
    Open in IDE #permalink
    /.npmrc Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /yarn.lock Added
    Open in IDE #permalink
    /src/openlmis-example/openlmis-example.module.js Changed
    Open in IDE #permalink
    /src/openlmis-example/openlmis-example.routes.js Changed
    Open in IDE #permalink
    /src/openlmis-example/openlmis-example.scss Added
    Open in IDE #permalink
    /src/openlmis-example/openlmis-example.spec.js Added
    Open in IDE #permalink
    /.npmrc Added
    Open in IDE #permalink
    /Gruntfile.js Added
    Open in IDE #permalink
    /docker-compose.yml Changed
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package-yarn.json Added
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /project.properties Added
    Open in IDE #permalink
    /version.properties Deleted
    Open in IDE #permalink
    /yarn.lock Added
    Open in IDE #permalink
    /.npmrc Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /build.sh Changed
    Open in IDE #permalink
    /npm-shrinkwrap.json Added
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /sonar.sh Changed
    Open in IDE #permalink
    /yarn.lock Added
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against