FEOLMIS-3341
OLMIS-3696: Added dependency locking
Details
| Participant | Role | Time Spent | Comments | Latest Comment |
|---|---|---|---|---|
| Author | 30m | 5 | What really is important are the changes in the dev-ui re... | |
| Reviewer - Complete | 7m | 1 | missing changelogs? | |
| Reviewer - Complete | 7m | 3 | I don't think we need to specifically say we've increased... | |
| Reviewer - Complete | 3m | 1 | These changes are virtually impossible to review in-depth. | |
| Total | 48m | 10 |
-
Linked issues
Branches in review
General Comments
Mateusz Kwiatkowski
Do we need any documentation? Something needs to be changed in release process?Do we need any documentation? Something needs to be changed in release process?
-
Mateusz Kwiatkowski
marked as
Resolved
01 Oct 18
Nikodem Graczewski
Not really, the release process stays the same. The only difference is that a...Not really, the release process stays the same. The only difference is that at some point we will have to update those dependencies so they don't go outdated.
Nikodem Graczewski
dev-ui version update has a separate review - FEOLMIS-3344.dev-ui version update has a separate review - FEOLMIS-3344.
Chongsun Ahn
These changes are virtually impossible to review in-depth.These changes are virtually impossible to review in-depth.
Nikodem Graczewski
What really is important are the changes in the dev-ui repository and package...What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. The change we're introducing here is locking dev-ui dependencies, which are no longer fetched to the node_modules in the root directory, but instead, are fetched into node_modules/dev-ui/node_modules. What we're doing is moving them to the node_modules directory so they are available to the module that is relying on dev-ui, lack of them there would break the build process because of missing dependencies. For yarn.lock we're basically copying the one generated in the .tmp directory, which is where we're firing yarn up during the build process. If you have any concern, please let me know. 
missing changelogs?
Łukasz Lewczyński marked as Resolved 01 Oct 18