OLMIS-4865: release requisition without order

Activity

FEOLMIS-3135 11

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 45m    
    Reviewer - 63% reviewed 39m    
    Reviewer - 63% reviewed 16m 2 Is there a unit test for the new function?
    Reviewer - Complete 42m 9 Tests are looking good, but can you fix indentation?
    Total   2h 23m 11  
    #permalink

    Objectives

    This change updates the convert to order button to use the new batchReleases resource. It also implements a new button on the convert to order screen to release requisitions without order.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    Mateusz Kwiatkowski Can you take a look? You are probably familiar with the U...

    Mateusz Kwiatkowski Can you take a look? You are probably familiar with the UI code more than I am.

    Mateusz Kwiatkowski

    Sure, looks good, I only left some small comments

    Sure, looks good, I only left some small comments

    /src/requisition/requisitions.service.js Changed 3
    /src/requisition/requisitions.service.spec.js Changed 1
    /src/requisition-convert-to-order/convert-to-order.controller.js Changed 2
    /src/requisition-convert-to-order/convert-to-order.controller.spec.js Changed
    /src/requisition-convert-to-order/convert-to-order.html Changed 1
    /src/requisition-convert-to-order/messages_en.json Changed
    /src/requisition-convert-to-order/requisitions-for-convert.factory.js Changed 1
    /src/requisition-convert-to-order/requisitions-for-convert.factory.spec.js Changed 1
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against