OLMIS-4792: Make dropdown in additional options column of requisition template...

Activity

FEOLMIS-2976 17

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 30m 6 Ah, Yes. It was mostly an endless loading screen or a whi...
    Reviewer - 0% reviewed      
    Reviewer - Complete 18m 7 LGFM
    Reviewer - Complete 7m 4 Great, you're most welcome! https://review.openlmis.org/s...
    Total   55m 17  
    #permalink

    Objectives

    OLMIS-4792: Make dropdown in additional options column of requisition template translatable.
    Change the labels of available requisition column options from human readable text to translatable key.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Elias

    Thanks for pointing me to the message filter. I have removed the translateLab...

    Thanks for pointing me to the message filter. I have removed the translateLabel method and used the "message" filter as recommended.
    Adding a change set to the review has been giving me an error. The change that I committed for resolving these issues is here.
    https://github.com/OpenLMIS/openlmis-requisition-ui/commit/4d7d0fd3770a1cb528524b2cc6f637b771d2ea36

    Łukasz Lewczyński

    Looks good but I don't see entries in changelogs

    Looks good but I don't see entries in changelogs

      Elias marked as Resolved 29 May 18

    Elias

    Done. Added changelog entries on both requisition and requisition UI reposito...

    Nikodem Graczewski

    I've added the related commits so we have everything in the same place https:...

    I've added the related commits so we have everything in the same place

    Elias

    Thanks Nikodem Graczewski

    Nikodem Graczewski

    Elias What kind of error were you encountering by the way? If it was and endl...

    Elias What kind of error were you encountering by the way? If it was and endless loading perhaps you're using http protocol instead of https when connecting to the Fisheye?

    Elias

    Ah, Yes. It was mostly an endless loading screen or a white screen. loading i...

    Ah, Yes. It was mostly an endless loading screen or a white screen. loading it on https:// seems to have fixed the issue. Thanks again.

    Nikodem Graczewski

    Great, you're most welcome! https://review.openlmis.org/static/ogdo0b/2static...

    Great, you're most welcome!

    /src/.../migration/20180518164621420__add_skipped_column_options.sql Changed 3
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /src/admin-template-configure-columns/requisition-template-admin.controller.js Changed 1
    /src/admin-template-configure-columns/template.html Changed 4
    /src/requisition-constants/messages_en.json Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against