OLMIS-4053: Group approve product methods into single class


FEOLMIS-2904 2

Keyboard shortcuts  
  • Summarize the review outcomes (optional)


    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 14m 1 done
    Reviewer - 0% reviewed 17m 1 can you rename it to ApproveProductsAggregator or somethi...
    Reviewer - Complete 2m    
    Reviewer - Complete 1m    
    Total   35m 2  


    All methods that are related with approved products should be placed in one class. Current approach is more OOP because we other part of the system does not know about the structure of approved products and they execute methods to retrieve necessary data.

    Branches in review


    Issues Raised From Comments

    Key Summary State Assignee

    General Comments

    There are no general comments on this review.
    /src/.../referencedata/ApproveProducts.java Deleted 2
    Open in IDE #permalink
    /src/.../referencedata/ApproveProductsAggregator.java Added
    Open in IDE #permalink
    /src/.../referencedata/ApprovedProductReferenceDataService.java Changed
    /src/main/.../service/RequisitionService.java Changed
    /src/.../referencedata/ApproveProductsAggregatorTest.java Added
    Open in IDE #permalink
    /src/.../referencedata/ApproveProductsTest.java Deleted
    Open in IDE #permalink
    /src/.../referencedata/ApprovedProductReferenceDataServiceTest.java Changed
    /src/.../service/RequisitionServiceTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time