FEOLMIS-2904 OLMIS-4053: Group approve product methods into single class

closed on 14 May 18

Author

Reviewers

OLMIS-4053: Group approve product methods into single class

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 8

openlmis-requisition 0
- Folder src 0
  - Folder main/java/org/openlmis/requisition/service 0
    - Folder referencedata 0
      - File ApproveProducts.java 2 Remove
      - File ApproveProductsAggregator.java 0 Remove
      - File ApprovedProductReferenceDataService.java 0 Remove
    - File RequisitionService.java 0 Remove
  - Folder test/java/org/openlmis/requisition/service 0
    - Folder referencedata 0
      - File ApproveProductsAggregatorTest.java 0 Remove
      - File ApproveProductsTest.java 0 Remove
      - File ApprovedProductReferenceDataServiceTest.java 0 Remove
    - File RequisitionServiceTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Łukasz Lewczyński	Author	14m	1	done
Paweł Albecki	Reviewer - 0% reviewed	17m	1	can you rename it to ApproveProductsAggregator or somethi...
Mateusz Kwiatkowski	Reviewer - Complete	2m
Nikodem Graczewski	Reviewer - Complete	1m
Total		35m	2

Linked issues
- OLMIS-4053

#permalink

Objectives

All methods that are related with approved products should be placed in one class. Current approach is more OOP because we other part of the system does not know about the structure of approved products and they execute methods to retrieve necessary data.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-2904

OLMIS-4053: Group approve product methods into single class

FEOLMIS-2904 2

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-4053: Group approve product methods into single class

FEOLMIS-2904 2

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time