FEOLMIS-2903 OLMIS-4053: moved finding req template for initiate to controller layer

closed on 14 May 18

Author

Reviewers

OLMIS-4053: moved finding req template for initiate to controller layer

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 7

openlmis-requisition 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/requisition/web 0
    - File BaseWebIntegrationTest.java 0 Remove
    - File RequisitionControllerIntegrationTest.java 0 Remove
  - Folder main/java/org/openlmis/requisition 0
    - Folder service 0
      - File RequisitionService.java 0 Remove
      - File RequisitionTemplateService.java 0 Remove
    - Folder web 0
      - File RequisitionController.java 2 Remove
  - Folder test/java/org/openlmis/requisition/service 0
    - File RequisitionServiceTest.java 0 Remove
    - File RequisitionTemplateServiceTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Łukasz Lewczyński	Author	8m	2	why? finding template is not related with requisition. I ...
Paweł Albecki	Reviewer - Complete	5m	2	No, just curious
Mateusz Kwiatkowski	Reviewer - Complete	1m	1	I'm little concerned about moving this retrieval here.
Total		15m	5

Linked issues
- OLMIS-4053

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Paweł Albecki

What are the objectives? Why code was moved? I think review title is misleadi...

What are the objectives? Why code was moved? I think review title is misleading? It was not moved to controller layer but other service

11 May 18

Łukasz Lewczyński

it was moved both into another service and to controller layer. I moved the c...

it was moved both into another service and to controller layer. I moved the code because the requisition service is too large and contains too many methods/functions. I try to use SOLID. If you think I do something incorrectly let me know

11 May 18

Paweł Albecki

No, just curious

11 May 18

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-2903

OLMIS-4053: moved finding req template for initiate to controller layer

FEOLMIS-2903 5

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paweł Albecki

Łukasz Lewczyński

Paweł Albecki

Log time

OLMIS-4053: moved finding req template for initiate to controller layer

FEOLMIS-2903 5

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paweł Albecki

Łukasz Lewczyński

Paweł Albecki

Log time