FEOLMIS-2901 OLMIS-4053: move skip functionality from service to domain

closed on 15 May 18

Author

Reviewers

OLMIS-4053: move skip functionality from service to domain

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 10

openlmis-requisition 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/requisition/web 0
    - File BaseWebIntegrationTest.java 0 Remove
    - File RequisitionControllerIntegrationTest.java 2 Remove
  - Folder main/java/org/openlmis/requisition 0
    - Folder domain/requisition 0
      - File Requisition.java 6 Remove
      - File SkipParams.java 6 Remove
    - Folder service 0
      - File RequisitionService.java 0 Remove
    - Folder web 0
      - File RequisitionController.java 4 Remove
  - Folder test/java/org/openlmis/requisition 0
    - Folder domain/requisition 0
      - File RequisitionTest.java 0 Remove
      - File SkipParamsTest.java 0 Remove
    - Folder service 0
      - File RequisitionServiceTest.java 0 Remove
    - Folder testutils 0
      - File ToStringTestUtils.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Łukasz Lewczyński	Author	24m	9	class has been removed
Paweł Albecki	Reviewer - 39% reviewed	4m	2	we shouldn't have need for testing logic in IT. If there ...
Mateusz Kwiatkowski	Reviewer - Complete	9m	4	Sorry but I'm not convinced, you explanation indicates th...
Nikodem Graczewski	Reviewer - Complete	11m	3	This seems weird to me. Why would requisition need those ...
Total		49m	18

Linked issues
- OLMIS-4053

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/src/main/.../requisition/SkipParams.java Deleted 6 (0)

Click to load diff

/src/test/.../requisition/SkipParamsTest.java Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-2901

OLMIS-4053: move skip functionality from service to domain

FEOLMIS-2901 18

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-4053: move skip functionality from service to domain

FEOLMIS-2901 18

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time