FEOLMIS-2899 OLMIS-4706: Design API for retrieving Stock out Days

closed on 21 May 18

Author

Reviewers

OLMIS-4706: Design API for retrieving Stock out Days

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 3

openlmis-stockmanagement 0
- Folder src/main/resources 0
  - Folder schemas 0
    - File stockOutDays.json 3 Remove
    - File stockOutDaysPage.json 0 Remove
  - File api-definition.yaml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Paweł Albecki	Author	2m	1	We return null when there is no stock cards
Nikodem Graczewski	Reviewer - 0% reviewed	1m
Łukasz Lewczyński	Reviewer - 0% reviewed	13m	3	Mateusz Kwiatkowski could you revert those changes if the...
Sebastian Brudziński	Reviewer - 0% reviewed	1m
Chongsun Ahn	Reviewer - 0% reviewed	15m	1	This API makes sense to me, but I am wondering why we are...
Mateusz Kwiatkowski	Reviewer - Complete	0m	1	done
Total		34m	6

Linked issues
- OLMIS-4706

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Chongsun Ahn

This API makes sense to me, but I am wondering why we are having a separate r...

This API makes sense to me, but I am wondering why we are having a separate resource for stockOutDays? Can't it be merged into the resource we design for OLMIS-4035? Then a client like requisition would only need to make one call to get all of its "window" stock management information (meaning info in a time period defined by start date and end date).

11 May 18

Mateusz Kwiatkowski

Resolved

21 May 18

Łukasz Lewczyński

Mateusz Kwiatkowski could you revert those changes if they are on the master ...

Mateusz Kwiatkowski could you revert those changes if they are on the master branch? The related ticket has been closed (as won't fix)

21 May 18

Mateusz Kwiatkowski

done

21 May 18

Click to load diff

/src/main/.../schemas/stockOutDaysPage.json Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-2899

OLMIS-4706: Design API for retrieving Stock out Days

FEOLMIS-2899 6

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Chongsun Ahn

Łukasz Lewczyński

Mateusz Kwiatkowski

Log time

OLMIS-4706: Design API for retrieving Stock out Days

FEOLMIS-2899 6

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Chongsun Ahn

Łukasz Lewczyński

Mateusz Kwiatkowski

Log time