FEOLMIS-2886 OLMIS-4172: Make program and product unique in ProgramOrderable

closed on 07 May 18

Author

Reviewers

OLMIS-4172: Make program and product unique in ProgramOrderable

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 22

openlmis-referencedata 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/referencedata 0
    - Folder repository 0
      - File FacilityTypeApprovedProductRepositoryIntegrationTest.java 0 Remove
      - File OrderableRepositoryIntegrationTest.java 0 Remove
      - File ProgramOrderableRepositoryIntegrationTest.java 0 Remove
    - Folder web 0
      - File FacilityTypeApprovedProductControllerIntegrationTest.java 0 Remove
      - File OrderableControllerIntegrationTest.java 0 Remove
  - Folder main 0
    - Folder java/org/openlmis/referencedata 0
      - Folder domain 0
        
        File Orderable.java 1 Remove
        
        File ProgramOrderable.java 0 Remove
      - Folder errorhandling 0
        
        File RefDataErrorHandling.java 0 Remove
      - Folder repository 0
        
        Folder custom 0
        
        Folder impl 0
        
        File FacilityTypeApprovedProductRepositoryImpl.java 0 Remove
        
        File ProgramOrderableRepositoryImpl.java 0 Remove
        
        File ProgramOrderableRepositoryCustom.java 0 Remove
        
        File OrderableRepository.java 0 Remove
        
        File ProgramOrderableRepository.java 0 Remove
      - Folder service 0
        
        File ProgramOrderableService.java 1 Remove
      - Folder util 0
        
        Folder messagekeys 0
        
        File OrderableMessageKeys.java 0 Remove
        
        File OrderableBuilder.java 0 Remove
    - Folder resources 0
      - Folder db/migration 0
        
        File 20180504135225615__add_unique_constraint_for_program_and_orderable_in_program_orderables.sql 0 Remove
      - File messages_en.properties 0 Remove
  - Folder test/java/org/openlmis/referencedata 0
    - Folder domain 0
      - File OrderableTest.java 0 Remove
    - Folder service 0
      - File ProgramOrderableServiceTest.java 0 Remove
    - Folder testbuilder 0
      - File OrderableDataBuilder.java 0 Remove
    - Folder util 0
      - File OrderableBuilderTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Paweł Albecki	Author	1m	2	Needed to make ProgramOrderables a list because HashSet s...
Łukasz Lewczyński	Reviewer - Complete	2m
Mateusz Kwiatkowski	Reviewer - Complete	2m
Sebastian Brudziński	Reviewer - 79% reviewed	14m
Total		20m	2

Linked issues
- OLMIS-4172

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/src/.../repository/ProgramOrderableRepositoryIntegrationTest.java Deleted

Click to load diff

/src/.../impl/ProgramOrderableRepositoryImpl.java Deleted

Click to load diff

/src/.../custom/ProgramOrderableRepositoryCustom.java Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-2886

OLMIS-4172: Make program and product unique in ProgramOrderable

FEOLMIS-2886 2

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-4172: Make program and product unique in ProgramOrderable

FEOLMIS-2886 2

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time