FEOLMIS-2880 OLMIS-4623: Reworked Add Reason modal to be a state

closed on 09 May 18

Author

Reviewers

OLMIS-4623: Reworked Add Reason modal to be a state

Activity

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Nikodem Graczewski	Author	1h 13m	11	Done as alert
Klaudia Pałkowska	Reviewer - Complete	1h	1	I'll add them.
Mateusz Kwiatkowski	Reviewer - 85% reviewed	29m	21	add jsdoc for this property
Paweł Albecki	Reviewer - 85% reviewed	11m	5	notification would make more sense
Łukasz Lewczyński	Reviewer - Complete	14m	1	Should we update version to 1.2.0 ? Or even 2.0.0? I mean...
Total		3h 9m	39

Linked issues
- OLMIS-4623

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Nikodem Graczewski

I really should have leave it as modal...

04 May 18

Click to load diff

/src/admin-reason-add/admin-reason-add.scss Deleted 1 (0)

Click to load diff

/src/admin-reason-form-modal/messages_en.json Deleted

Click to load diff

/src/admin-reason-form-modal/reason-form-modal.controller.js Deleted

Click to load diff

/src/admin-reason-form-modal/reason-form-modal.controller.spec.js Deleted

Click to load diff

/src/admin-reason-form-modal/reason-form-modal.factory.js Deleted

Click to load diff

/src/admin-reason-form-modal/reason-form-modal.html Deleted

Click to load diff

/src/admin-reason-form-modal/reason-form-modal.module.js Deleted

Click to load diff

/src/admin-reason-form-modal/reason-form-modal.scss Deleted

Click to load diff

/src/admin-reason-list/reason-list.service.js Deleted

Click to load diff

/src/admin-reason-list/reason-list.service.spec.js Deleted

Click to load diff

/src/stock-valid-reason/valid-reason.service.js Deleted

Click to load diff

/src/stock-valid-reason/valid-reason.service.spec.js Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-2880

OLMIS-4623: Reworked Add Reason modal to be a state

FEOLMIS-2880 39

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Nikodem Graczewski

Log time

OLMIS-4623: Reworked Add Reason modal to be a state

FEOLMIS-2880 39

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Nikodem Graczewski

Log time