OLMIS-4105 Support alert_id in DTO to be a non-UUID string

Activity

FEOLMIS-2672 7

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 14m 3 I found a way to avoid changing "en-US" to "en_US".
    Reviewer - Complete 13m 4 lgtm.
    Total   27m 7  
    #permalink

    Objectives

    • Review new field, externalId.
    • Review new validation on it, and also validation that status keys are locales.
    • Review new repository query methods (and usage in controller) to search by external id (for update).
    • Review demo data change.
    • Review UI changing "en-US" key to "en_US" key, because I can't find any way to do something like {{ obj['this-key'] }} in Angular.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Josh Zamor

    This looks good, left one comment. Could we send the UI review question to Te...

    This looks good, left one comment. Could we send the UI review question to Team Parrot where they might know how it works in Angular?

    Chongsun Ahn

    I did ask the question in the Slack #ui channel, but got no response. I also ...

    I did ask the question in the Slack #ui channel, but got no response. I also scoured the Internetz for any answers. I didn't ask anyone specifically though.

    Chongsun Ahn

    I found a way to avoid changing "en-US" to "en_US".

    I found a way to avoid changing "en-US" to "en_US".

    /demo-data/cce.cce_alert_status_messages.json Changed
    /demo-data/cce.cce_alerts.json Changed
    /src/.../repository/AlertRepositoryIntegrationTest.java Changed
    /src/.../web/AlertControllerIntegrationTest.java Changed
    /src/main/java/.../cce/domain/Alert.java Changed
    /src/main/java/.../cce/dto/AlertDto.java Changed
    /src/main/.../cce/i18n/AlertMessageKeys.java Changed
    /src/main/.../repository/AlertRepository.java Changed
    /src/main/.../validator/AlertValidator.java Changed
    /src/main/.../cce/web/AlertController.java Changed
    /src/.../migration/20180216055219230__create_cce_alerts.sql Changed
    /src/main/resources/messages_en.properties Changed
    /src/test/java/.../cce/domain/AlertTest.java Changed
    /src/.../validator/AlertValidatorTest.java Changed 3
    /src/cce-alert/cce-alert.factory.js Changed
    /src/cce-alert/cce-alert.factory.spec.js Changed
    /src/cce-inventory-item-status/status-update-modal.controller.js Changed
    /src/cce-inventory-item-status/status-update-modal.html Changed
    /src/cce-inventory-list/cce-inventory-list.controller.js Changed
    /src/cce-inventory-list/rtm-alerts-popover.html Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time