OLMIS-4127 Add CCE alert module

Activity

FEOLMIS-2615 46

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 42m 14 Service is now repository impl.
    Reviewer - 0% reviewed 48m 27 I would like to see the UI drift to a more standardized f...
    Reviewer - Complete 20m 5 I think this should be called CceAlertRepository as Camme...
    Total   1h 51m 46  
    #permalink

    Objectives

    • Review CCE alert service setup.
    • Review CCE alert factory - transforming alert array to a map by device ID.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    This is to provide data for the other two related reviews.

    This is to provide data for the other two related reviews.

    Chongsun Ahn

    New changes--I believe I have addressed all issues except the RepositoryImpl.

    New changes--I believe I have addressed all issues except the RepositoryImpl.

    Chongsun Ahn

    Service is now repository impl.

    Service is now repository impl.

    /src/cce-alert/cce-alert-data-builder.js Added
    /src/cce-alert/cce-alert-repository-impl.js Added
    Open in IDE #permalink
    /src/cce-alert/cce-alert-repository-impl.spec.js Added
    Open in IDE #permalink
    /src/cce-alert/cce-alert-repository.js Added 1
    Open in IDE #permalink
    /src/cce-alert/cce-alert-repository.spec.js Added
    Open in IDE #permalink
    /src/cce-alert/cce-alert.factory.js Added 5
    /src/cce-alert/cce-alert.factory.spec.js Added 6
    /src/cce-alert/cce-alert.js Added 1
    /src/cce-alert/cce-alert.module.js Added
    Open in IDE #permalink
    /src/cce-alert/cce-alert.service.js Deleted 26
    Open in IDE #permalink
    /src/cce-alert/cce-alert.service.spec.js Deleted 1
    Open in IDE #permalink
    /src/cce-alert/messages_en.json Deleted 3
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time