OLMIS-2921: Status Update modal buttons will now take users to the correct pages

Activity

FEOLMIS-1902 20

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 51m 7 https://openlmis.atlassian.net/browse/?focusedCommentId=4...
    Reviewer - Complete 54m 11 (2 defects) Nikodem Graczewski – this looks good I resolved the last...
    Reviewer - 56% reviewed 35m 2 Nikodem Graczewski I don't get why we droped vm here.... ...
    Total   2h 21m 20 (2 defects)  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Nikodem Graczewski

    https://openlmis.atlassian.net/browse/?focusedCommentId=44322&page=com.atlass...

    https://openlmis.atlassian.net/browse/?focusedCommentId=44322&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#OLMIS-2921comment-44322

    Nick Reid

    Nikodem Graczewski – this looks good I resolved the last issue I had, as it ...

    Nikodem Graczewski – this looks good

    I resolved the last issue I had, as it looks like the tests were simplified

    /src/cce-add-inventory-item/add-inventory-item.html.spec.js Changed
    /src/cce-add-inventory-item/cce-add-inventory-item.routes.js Changed 3
    Open in IDE #permalink
    /src/cce-edit-inventory-item/cce-edit-inventory-item.routes.js Changed
    /src/cce-edit-inventory-item/edit-inventory-item.controller.js Changed 2
    /src/cce-edit-inventory-item/edit-inventory-item.controller.spec.js Changed
    /src/cce-edit-inventory-item/edit-inventory-item.html Changed
    /src/cce-edit-inventory-item/edit-inventory-item.html.spec.js Changed
    /src/cce-edit-inventory-item/messages_en.json Changed
    Open in IDE #permalink
    /src/cce-inventory-item/inventory-item-program.filter.js Added 1
    Open in IDE #permalink
    /src/cce-inventory-item/inventory-item-program.filter.spec.js Added
    Open in IDE #permalink
    /src/cce-inventory-item-details/inventory-item-details.html Changed 1
    /src/cce-inventory-item-details/inventory-item-details.scss Changed
    /src/cce-inventory-item-details/inventory-item-program.filter.js Deleted
    Open in IDE #permalink
    /src/cce-inventory-item-details/inventory-item-program.filter.spec.js Deleted
    Open in IDE #permalink
    /src/cce-inventory-item-status/cce-inventory-item-status.module.js Changed
    /src/cce-inventory-item-status/status-update-modal.controller.js Changed 4
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js Changed 1
    /src/cce-inventory-item-status/status-update-modal.html Changed
    /src/cce-inventory-item-status/status-update-modal.html.spec.js Changed 5
    /src/openlmis-state-tracker/state-tracker.service.js Changed
    /src/openlmis-state-tracker/state-tracker.service.spec.js Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time