OLMIS-2897: Added Update Status modal

Activity

FEOLMIS-1795 7

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 16m 1 I can do that. https://review.openlmis.org/static/ql0uca/...
    Reviewer - Complete 24h 4 (2 defects) Overall this looks good — I'd like to figure out how to t...
    Reviewer - Complete 6m 2 I think that the problem is you don't have any catalog it...
    Total   24h 22m 7 (2 defects)  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Nick Reid

    Overall this looks good — I'd like to figure out how to test it, but am unsur...

    Overall this looks good — I'd like to figure out how to test it, but am unsure of who to login as

    Mateusz Kwiatkowski

    I think that the problem is you don't have any catalog items added so you can...

    I think that the problem is you don't have any catalog items added so you can add some using csv file.

    Mateusz Kwiatkowski

    Nick Reid all of unresolved comments were corrected in commit for other ticke...
    /src/cce-add-inventory-item/add-inventory-item.controller.js Changed
    /src/cce-add-inventory-item/add-inventory-item.controller.spec.js Changed
    /src/cce-add-inventory-item/add-inventory-item.html.spec.js Changed
    /src/cce-inventory-item/cce-inventory-item.service.js Changed
    /src/cce-inventory-item/cce-inventory-item.service.spec.js Changed
    /src/cce-inventory-item-status/cce-inventory-item-status.module.js Added
    Open in IDE #permalink
    /src/cce-inventory-item-status/cce-inventory-item-status.routes.js Added
    Open in IDE #permalink
    /src/cce-inventory-item-status/cce-inventory-item-status.routes.spec.js Added
    Open in IDE #permalink
    /src/cce-inventory-item-status/functional-status.constant.js Added
    Open in IDE #permalink
    /src/cce-inventory-item-status/messages_en.json Added
    Open in IDE #permalink
    /src/cce-inventory-item-status/reason-for-not-working.constant.js Added
    Open in IDE #permalink
    /src/cce-inventory-item-status/status-update-modal.controller.js Added
    Open in IDE #permalink
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js Added
    Open in IDE #permalink
    /src/cce-inventory-item-status/status-update-modal.html Added 4
    Open in IDE #permalink
    /src/cce-inventory-item-status/status-update-modal.html.spec.js Added
    Open in IDE #permalink
    /src/cce-inventory-list/cce-intentory-list.module.js Changed
    /src/cce-inventory-list/cce-inventory-list.controller.js Changed
    /src/cce-inventory-list/cce-inventory-list.controller.spec.js Changed
    /src/cce-inventory-list/cce-inventory-list.html Changed
    /src/cce-inventory-list/functional-status.constant.js Deleted
    Open in IDE #permalink
    /src/cce-inventory-list/status.scss Deleted
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time