OLMIS-2619: Added Edit Inventory Item modal

Activity

FEOLMIS-1792 25

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 27m 6 It's a reflection of this ENUM: https://github.com/OpenLM...
    Reviewer - 85% reviewed 1h 18m 14 (2 defects) Yea, that looks about right... make the dt width 10em......
    Reviewer - Complete 2h 49m 5 Nick Reid I've changed this to sub-heading markup from st...
    Total   4h 34m 25 (2 defects)  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Nick Reid

    Overall this looks good!

    Overall this looks good!

    /src/cce-add-inventory-item/add-inventory-item.controller.js Changed
    /src/cce-add-inventory-item/add-inventory-item.controller.spec.js Changed
    /src/cce-add-inventory-item/add-inventory-item.html Changed 3
    /src/cce-add-inventory-item/add-inventory-item.html.spec.js Changed
    /src/cce-add-inventory-item/cce-add-inventory-item.module.js Changed
    /src/cce-add-inventory-item/messages_en.json Changed
    /src/cce-edit-inventory-item/cce-edit-inventory-item.module.js Added
    Open in IDE #permalink
    /src/cce-edit-inventory-item/cce-edit-inventory-item.routes.js Added
    /src/cce-edit-inventory-item/cce-edit-inventory-item.routes.spec.js Added
    Open in IDE #permalink
    /src/cce-edit-inventory-item/edit-inventory-item.controller.js Added
    /src/cce-edit-inventory-item/edit-inventory-item.controller.spec.js Added
    /src/cce-edit-inventory-item/edit-inventory-item.html Added 10
    /src/cce-edit-inventory-item/edit-inventory-item.html.spec.js Added 3
    /src/cce-edit-inventory-item/edit-inventory-item.scss Deleted
    Open in IDE #permalink
    /src/cce-edit-inventory-item/messages_en.json Added
    /src/cce-inventory-item/cce-inventory-factory.js Added
    Open in IDE #permalink
    /src/cce-inventory-item/cce-inventory-factory.spec.js Added
    Open in IDE #permalink
    /src/cce-inventory-item/cce-inventory-item.module.js Changed
    /src/cce-inventory-item/cce-inventory-item.service.js Changed
    /src/cce-inventory-item/cce-inventory-item.service.spec.js Changed
    /src/cce-inventory-item/cce-status.constant.js Added 2
    /src/cce-inventory-item/cce-status.constant.spec.js Added
    Open in IDE #permalink
    /src/cce-inventory-item/make-model.filter.js Added
    Open in IDE #permalink
    /src/cce-inventory-item/manual-temperature-gauge-type.constant.js Added 3
    Open in IDE #permalink
    /src/cce-inventory-item/manual-temperature-gauge-type.constant.spec.js Added
    Open in IDE #permalink
    /src/cce-inventory-item/messages_en.json Added
    Open in IDE #permalink
    /src/cce-inventory-item/remote-temperature-monitor-type.constant.js Added
    Open in IDE #permalink
    /src/cce-inventory-item/remote-temperature-monitor-type.constant.spec.js Added
    Open in IDE #permalink
    /src/cce-inventory-item/utilization-status.constant.js Added
    Open in IDE #permalink
    /src/cce-inventory-item/utilization-status.constant.spec.js Added
    Open in IDE #permalink
    /src/cce-inventory-item-status/messages_en.json Changed
    /src/cce-inventory-item-status/status-update-modal.controller.js Changed
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js Changed
    /src/cce-inventory-item-status/status-update-modal.html Changed
    /src/cce-inventory-item-status/status-update-modal.html.spec.js Changed
    /src/cce-inventory-item-status/status-update.scss Deleted 2
    Open in IDE #permalink
    /src/cce-inventory-item-status/status.scss Added 1
    /src/cce-inventory-list/cce-inventory-list.html Changed
    /docker-compose.yml Changed
    /src/common/horizontal-definition-list.scss Added
    Open in IDE #permalink
    /src/openlmis-form/form.scss Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time