FEOLMIS-1768 OLMIS-2622: Display error and success messages for upload cce

closed on 31 Jul 17

Author

Reviewers

OLMIS-2622: Display error and success messages for upload cce

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 9

openlmis-cce 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/cce/web 0
    - File CatalogItemControllerIntegrationTest.java 0 Remove
  - Folder main 0
    - Folder java/org/openlmis/cce 0
      - Folder dto 0
        
        File UploadResultDto.java 0 Remove
      - Folder web 0
        
        File CatalogItemController.java 0 Remove
    - Folder resources 0
      - Folder schemas 0
        
        File uploadResult.json 0 Remove
      - File api-definition.yaml 0 Remove
openlmis-cce-ui 0
- Folder src/admin-cce-upload 0
  - File cce-upload.controller.js 2 Remove
  - File cce-upload.controller.spec.js 0 Remove
  - File cce-upload.html 0 Remove
  - File messages_en.json 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Paweł Nawrocki	Author	9m	1	Fixed
Nikodem Graczewski	Reviewer - 0% reviewed
Mateusz Kwiatkowski	Reviewer - Complete	3m	1	@description should be above text
Total		13m	2

Linked issues
- OLMIS-2622

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-1768

OLMIS-2622: Display error and success messages for upload cce

FEOLMIS-1768 2

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-2622: Display error and success messages for upload cce

FEOLMIS-1768 2

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time