FEOLMIS-1765 OLMIS-2911: added 2 fields to jasper template parameter

closed on 31 Jul 17

Author

Reviewers

OLMIS-2911: added 2 fields to jasper template parameter

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 11

openlmis-report 0
- Folder src/main 0
  - Folder java/org/openlmis/report 0
    - Folder domain 0
      - File JasperTemplateParameter.java 0 Remove
    - Folder dto 0
      - File JasperTemplateParameterDto.java 0 Remove
  - Folder resources 0
    - Folder db/migration 0
      - File 20170731115053512__jasper_template_parameter_additional_columns.sql 0 Remove
    - Folder schemas 0
      - File jasperTemplateParameterDto.json 0 Remove
openlmis-report-ui 0
- Folder src/report 0
  - File report.factory.js 0 Remove
  - File report.service.js 0 Remove
openlmis-requisition 0
- Folder demo-data 0
  - File requisition.template_parameters.json 0 Remove
- Folder src/main 0
  - Folder java/org/openlmis/requisition 0
    - Folder domain 0
      - File JasperTemplateParameter.java 1 Remove
    - Folder dto 0
      - File JasperTemplateParameterDto.java 0 Remove
  - Folder resources 0
    - Folder db/migration 0
      - File 20170728191010624__jasper_tempalte_parameter_aditional_columns.sql 0 Remove
    - Folder schemas 0
      - File jasperTemplateParameterDto.json 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Mateusz Kwiatkowski	Author	22m
Paweł Nawrocki	Reviewer - Complete	11m	3	Looks good
Paweł Albecki	Reviewer - 0% reviewed
Total		34m	3

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Paweł Nawrocki

Once this is resolved, please commit the same to report service.

28 Jul 17

Paweł Nawrocki

Resolved

31 Jul 17

Paweł Nawrocki

Looks good

31 Jul 17

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-1765

OLMIS-2911: added 2 fields to jasper template parameter

FEOLMIS-1765 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paweł Nawrocki

Paweł Nawrocki

Log time

OLMIS-2911: added 2 fields to jasper template parameter

FEOLMIS-1765 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paweł Nawrocki

Paweł Nawrocki

Log time