OLMIS-2896: added catalog item dto and facility dto to inventory item dto

Activity

FEOLMIS-1763 20

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 2m 1 WIthout this line I get error saying that I cannot save i...
    Reviewer - 74% reviewed 10m 2 We could also add $ref
    Reviewer - Complete 38m 11 LGTM
    Reviewer - 48% reviewed 28m 6 Yes, we need to get into a habit of not modifying migrati...
    Total   2h 18m 20  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    /src/.../repository/InventoryItemRepositoryIntegrationTest.java Changed 2
    /src/.../web/InventoryItemControllerIntegrationTest.java Changed
    /src/main/java/.../cce/domain/CatalogItem.java Changed
    /src/main/.../cce/domain/InventoryItem.java Changed 5
    /src/main/.../cce/dto/InventoryItemDto.java Changed 1
    /src/.../i18n/InventoryItemMessageKeys.java Changed
    /src/main/java/.../cce/i18n/MessageKeys.java Changed
    /src/main/.../i18n/ValidationMessageKeys.java Deleted 1
    Open in IDE #permalink
    /src/.../referencedata/FacilityReferenceDataService.java Added
    Open in IDE #permalink
    /src/.../validator/InventoryItemValidator.java Added 1
    /src/main/.../web/InventoryItemController.java Changed 2
    /src/main/.../web/InventoryItemDtoBuilder.java Added 1
    /src/.../migration/20170720141040004__create_table_cce_inventory.sql Changed 3
    /src/.../migration/20170801113005321__inventory_changed_column_name.sql Added
    Open in IDE #permalink
    /src/main/.../schemas/basicFacilityDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/geographicLevelDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/geographicZoneDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/inventoryItem.json Changed 2
    /src/main/resources/messages_en.properties Changed
    /src/.../validator/InventoryItemValidatorTest.java Added 1

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time