FEOLMIS-1740 OLMIS-2760: Added requiredRights parameter to jasper templates

closed on 28 Jul 17

Author

Reviewers

OLMIS-2760: Added requiredRights parameter to jasper templates

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 17

openlmis-report 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/report 0
    - Folder repository 0
      - File JasperTemplateRepositoryIntegrationTest.java 0 Remove
    - Folder web 0
      - File JasperTemplateControllerIntegrationTest.java 2 Remove
  - Folder main 0
    - Folder java/org/openlmis/report 0
      - Folder domain 0
        
        File JasperTemplate.java 2 Remove
        
        File JasperTemplateParameter.java 0 Remove
      - Folder dto 0
        
        File JasperTemplateDto.java 1 Remove
        
        File JasperTemplateParameterDto.java 0 Remove
      - Folder exception 0
        
        File BaseLocalizedException.java 0 Remove
      - Folder i18n 0
        
        File AuthorizationMessageKeys.java 0 Remove
        
        File MessageKeys.java 0 Remove
      - Folder service 0
        
        File JasperTemplateService.java 2 Remove
        
        File PermissionService.java 1 Remove
      - Folder web 0
        
        File JasperTemplateController.java 0 Remove
    - Folder resources 0
      - Folder db/migration 0
        
        File 20170724135757991__jasper_template_add_required_rights_relation.sql 1 Remove
      - Folder schemas 0
        
        File jasperTemplateDto.json 0 Remove
      - File api-definition.yaml 0 Remove
  - Folder test/java/org/openlmis/report/service 0
    - File JasperTemplateServiceTest.java 3 Remove
    - File PermissionServiceTest.java 4 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Paweł Nawrocki	Author	30m	1	Paweł Albecki review updated
Paweł Gesek	Reviewer - 0% reviewed
Paweł Albecki	Reviewer - Complete	50m	17	LGTM
Total		1h 20m	18

Linked issues
- OLMIS-2760

#permalink

Objectives

The objective is to create a possibility for specifying list of rights required to print a report. Supervision rights are not supported. This is to allow OLMIS-2760 progression.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Paweł Nawrocki

Paweł Albecki review updated

28 Jul 17

Paweł Albecki

LGTM

28 Jul 17

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-1740

OLMIS-2760: Added requiredRights parameter to jasper templates

FEOLMIS-1740 18

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paweł Nawrocki

Paweł Albecki

Log time

OLMIS-2760: Added requiredRights parameter to jasper templates

FEOLMIS-1740 18

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paweł Nawrocki

Paweł Albecki

Log time