Clone
Tools

 

pfcui <cuipengfei2008@gmail.com> in openlmis-stockmanagement-ui

About

71 commits
  • Committer is not mapped to a user
  • First commit: 27 March 2017
  • Last commit: 27 May 2017
Last Week All Time
Commits: 0 71

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Saturday 27 May 2017
5:49 am

pfcui <cuipengfei2008@gmail.com>

bump version back to 1.0.0-snapshot

Options
    • -1
    • +1
    /version.properties
5:46 am

pfcui <cuipengfei2008@gmail.com>

fix bug in released version

Options
    • -1
    • +1
    /version.properties
5:44 am

pfcui <cuipengfei2008@gmail.com>

bug of OLMIS-2513 add lot message to physical inventory draft page as well

Options
    • -2
    • +3
    /src/stock-orderable-lot-util/orderable-lot-util.service.js
    • -0
    • +1
    /src/stock-physical-inventory-draft/physical-inventory-draft.controller.js
    • -1
    • +2
    /src/stock-physical-inventory-draft/physical-inventory-draft.module.js
    • -3
    • +9
    /src/stock-physical-inventory-draft/physical-inventory-draft.routes.js
Friday 26 May 2017
10:35 am

pfcui <cuipengfei2008@gmail.com>

[stock management] use flyway to init data

Options
    • -1
    • +1
    /local-web-test/docker-compose.yml
Thursday 25 May 2017
8:35 am

pfcui <cuipengfei2008@gmail.com>

[performance] make http request page size 100

Options
    • -4
    • +9
    /src/stock-card-summaries/card-summaries.service.js
Tuesday 23 May 2017
8:54 am

pfcui <cuipengfei2008@gmail.com>

OLMIS-2544 remove front end validation when decreasing soh. let back end do that. because without holding all stock card line items, front end can not do it right.

Options
    • -23
    • +3
    /src/stock-adjustment-creation/adjustment-creation.controller.js
    • -27
    • +0
    /src/stock-adjustment-creation/adjustment-creation.controller.spec.js
Wednesday 17 May 2017
7:18 am

pfcui <cuipengfei2008@gmail.com>

[fix] in physical inventory draft page, if an orderable has already been added with 'no lot defined', then do not let 'no lot defined' show up in modal as an option

Options
    • -1
    • +7
    /src/stock-orderable-lot-util/orderable-lot-util.service.js
Friday 12 May 2017
7:34 am

pfcui <cuipengfei2008@gmail.com>

[feedback] in adjustment/issue/receive page, hide lot field when selected product has no lot and when lot field is displayed, do not auto select the first option

Options
    • -2
    • +19
    /src/stock-adjustment-creation/adjustment-creation.controller.js
    • -5
    • +8
    /src/stock-adjustment-creation/adjustment-creation.html
7:18 am

pfcui <cuipengfei2008@gmail.com>

[feedback] make lot drop down list disappear if selected product has no lot and do not give lot drop down list default value

Options
    • -5
    • +12
    /src/stock-add-products-modal/add-products-modal.controller.js
    • -1
    • +2
    /src/stock-add-products-modal/add-products-modal.controller.spec.js
    • -3
    • +5
    /src/stock-add-products-modal/add-products-modal.html
    • -2
    • +4
    /src/stock-orderable-lot-util/orderable-lot-util.service.js
Thursday 11 May 2017
8:02 am

pfcui <cuipengfei2008@gmail.com>

OLMIS-2508 add no lot defined as an option into drop down list

Options
    • -0
    • +3
    /src/stock-orderable-lot-util/messages_en.json
    • -7
    • +10
    /src/stock-orderable-lot-util/orderable-lot-util.service.js
    • -1
    • +2
    /src/stock-orderable-lot-util/orderable-lot-util.service.spec.js
Wednesday 10 May 2017
4:30 am

pfcui <cuipengfei2008@gmail.com>

[small bug] if soh is zero, user should not be able to issue it

Options
    • -1
    • +9
    /src/stock-issue-creation/issue-creation.routes.js
Thursday 04 May 2017
3:43 am

pfcui <cuipengfei2008@gmail.com>

[refactor] move logic of getting all lots of one orderable group into service

Options
    • -3
    • +1
    /src/stock-add-products-modal/add-products-modal.controller.js
    • -2
    • +4
    /src/stock-add-products-modal/add-products-modal.controller.spec.js
    • -3
    • +1
    /src/stock-adjustment-creation/adjustment-creation.controller.js
    • -3
    • +5
    /src/stock-adjustment-creation/adjustment-creation.controller.spec.js
    • -1
    • +1
    /src/stock-adjustment-creation/adjustment-creation.module.js
    • -1
    • +5
    /src/stock-orderable-lot-util/orderable-lot-util.service.js
    • -0
    • +78
    /src/stock-orderable-lot-util/orderable-lot-util.service.spec.js
3:39 am

pfcui <cuipengfei2008@gmail.com>

[refactor] move logic of finding one item by lot into common service

Options
    • -6
    • +2
    /src/stock-add-products-modal/add-products-modal.controller.js
    • -6
    • +2
    /src/stock-adjustment-creation/adjustment-creation.controller.js
    • -0
    • +9
    /src/stock-orderable-lot-util/orderable-lot-util.service.js
3:32 am

pfcui <cuipengfei2008@gmail.com>

[refactor] introduce a common service to take care of orderable and lot identity

Options
    • -6
    • +5
    /src/stock-add-products-modal/add-products-modal.controller.js
    • -1
    • +2
    /src/stock-add-products-modal/add-products-modal.module.js
    • -7
    • +5
    /src/stock-adjustment-creation/adjustment-creation.controller.js
    • -0
    • +1
    /src/stock-adjustment-creation/adjustment-creation.module.js
    • -0
    • +26
    /src/stock-orderable-lot-util/orderable-lot-util.module.js
    • -0
    • +44
    /src/stock-orderable-lot-util/orderable-lot-util.service.js
Tuesday 02 May 2017
3:33 am

pfcui <cuipengfei2008@gmail.com>

[bug] FIX bug of child state resolve twice

Options
    • -1
    • +3
    /src/stock-card-summaries/card-summaries.routes.js
    • -4
    • +3
    /src/stock-card/stock-card.routes.js
Friday 28 Apr 2017
8:49 am

pfcui <cuipengfei2008@gmail.com>

[bug] add bug description in code, wait for stack overflow or github issues to respond

Options
    • -1
    • +6
    /src/stock-physical-inventory-draft/physical-inventory-draft.routes.js
Wednesday 26 Apr 2017
8:45 am

pfcui <cuipengfei2008@gmail.com>

[UI Feedback] show reason name and reason free text in single card page

Options
    • -0
    • +1
    /src/stock-card/messages_en.json
    • -1
    • +6
    /src/stock-card/stock-card.html
7:02 am

pfcui <cuipengfei2008@gmail.com>

remove tmp file

Options
    • -22
    • +0
    /a.txt
7:01 am

pfcui <cuipengfei2008@gmail.com>

[bug] fix bug: input box, when it has error, make its color red, not half red half blue

Options
    • -1
    • +3
    /src/stock-add-products-modal/add-products-modal.html
    • -0
    • +1
    /src/stock-physical-inventory-draft/physical-inventory-draft.html
6:52 am

pfcui <cuipengfei2008@gmail.com>

[bug] fix bug: input box changed its behavior, now if a input box is empty, its value is "", not null. so we have to change our code accordingly

Options
    • -0
    • +22
    /a.txt
    • -2
    • +4
    /src/stock-physical-inventory-draft/physical-inventory-draft.controller.js
6:18 am

pfcui <cuipengfei2008@gmail.com>

[bug] fix bug: when a stock card's soh is 0(zero), so it in draft page

Options
    • -2
    • +3
    /src/stock-physical-inventory-draft/physical-inventory-draft.routes.js
Tuesday 25 Apr 2017
9:47 am

pfcui <cuipengfei2008@gmail.com>

[Code review] because added items can be product or product+lot, change text to "items"

Options
    • -1
    • +1
    /src/stock-add-products-modal/messages_en.json
8:11 am

pfcui <cuipengfei2008@gmail.com>

[Code review] use a smaller data set to determine which item is the selected one in add product modal

Options
    • -22
    • +16
    /src/stock-add-products-modal/add-products-modal.controller.js
    • -3
    • +3
    /src/stock-add-products-modal/add-products-modal.controller.spec.js
    • -3
    • +4
    /src/stock-add-products-modal/add-products-modal.html
7:46 am

pfcui <cuipengfei2008@gmail.com>

[Code review] underscore filter.first is same as find

Options
    • -2
    • +2
    /src/stock-add-products-modal/add-products-modal.controller.js
7:03 am

pfcui <cuipengfei2008@gmail.com>

[Code review] no need to check if orderable is chosen in add products modal, form will prevent it from submitting

Options
    • -12
    • +10
    /src/stock-add-products-modal/add-products-modal.controller.js
6:14 am

pfcui <cuipengfei2008@gmail.com>

[UI Feedback] change header text in single card page

Options
    • -1
    • +1
    /src/stock-card/messages_en.json
    • -3
    • +5
    /src/stock-card/stock-card.html
    • -1
    • +1
    /src/stock-card/stock-card.scss
6:04 am

pfcui <cuipengfei2008@gmail.com>

[UI Feedback] right align numbers in single card page

Options
    • -3
    • +3
    /src/stock-card/stock-card.html
Monday 24 Apr 2017
9:42 am

pfcui <cuipengfei2008@gmail.com>

OLMIS-2362 do not display lot related information in add products modal when all line items have no lot

Options
    • -2
    • +13
    /src/stock-add-products-modal/add-products-modal.controller.js
    • -0
    • +1
    /src/stock-add-products-modal/add-products-modal.controller.spec.js
    • -5
    • +6
    /src/stock-add-products-modal/add-products-modal.html
    • -1
    • +4
    /src/stock-add-products-modal/add-products-modal.service.js
    • -1
    • +1
    /src/stock-physical-inventory-draft/physical-inventory-draft.controller.js
    • -1
    • +1
    /src/stock-physical-inventory-draft/physical-inventory-draft.controller.spec.js
9:26 am

pfcui <cuipengfei2008@gmail.com>

OLMIS-2362 do not display lot related information in draft page when all line items have no lot

Options
    • -0
    • +3
    /src/stock-physical-inventory-draft/physical-inventory-draft.controller.js
    • -4
    • +6
    /src/stock-physical-inventory-draft/physical-inventory-draft.html
9:17 am

pfcui <cuipengfei2008@gmail.com>

OLMIS-2362 submit physical inventory with lot id

Options
    • -0
    • +1
    /src/stock-physical-inventory-draft/physical-inventory-draft.service.js