Clone
Tools

 

paweł gesek <pgesek@soldevelo.com> in openlmis-report-ui

About

37 commits
  • Mapped user: Paweł Gesek
  • First commit: 27 October 2016
  • Last commit: 29 November 2022
Last Week All Time
Commits: 0 37

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Tuesday 29 Nov 2022
4:22 pm

Paweł Gesek

Merge pull request #12 from OpenLMIS/fixbranch

Update yarn, jenkinsfile, npm-shrinkwrap

Options
Wednesday 26 Jul 2017
10:57 am

Paweł Gesek

Merge pull request #6 from OpenLMIS/enum-input-fix

Fix enum inputs not showing up

Options
Wednesday 22 Mar 2017
4:01 pm

Paweł Gesek

Switch param order

The param order is an issue for some people

Options
    • -1
    • +1
    /README.md
Wednesday 08 Mar 2017
3:50 pm

Paweł Gesek

OLMIS-2068: Validate the entire line item

We validate the entire line item upon update to the grid.

Thanks to this calculations will also go through validation.

This required calling dependency update (calculations) manually

before validating, because ng-change is called before $watchers.

Options
    • -2
    • +2
    /src/main/webapp/requisition-product-grid/product-grid-cell.directive.js
    • -10
    • +32
    /src/main/webapp/requisition-product-grid/product-grid-cell.directive.spec.js
    • -1
    • +6
    /src/main/webapp/requisition-validation/requisition-validator.factory.js
    • -0
    • +12
    /src/main/webapp/requisition-validation/requisition-validator.factory.spec.js
Tuesday 07 Mar 2017
3:54 pm

Paweł Gesek

OLMIS-2006: Improved report JSDocs

* Added @description

* Moved @name below @methodOf/@propertyOf

* Formatted params/returns into columns

* Function -> method

Options
    • -6
    • +6
    /src/main/webapp/report/report-generate.controller.js
    • -1
    • +1
    /src/main/webapp/report/report-list.controller.js
    • -25
    • +26
    /src/main/webapp/report/report.factory.js
    • -1
    • +3
    /src/main/webapp/report/report.module.js
    • -14
    • +14
    /src/main/webapp/report/report.service.js
Monday 06 Mar 2017
6:30 pm

Paweł Gesek

OLMIS-2006: Added report factory spec

Options
    • -0
    • +150
    /src/main/webapp/report/report.factory.spec.js
6:29 pm

Paweł Gesek

Remove unused var from period.factory.spec

Options
    • -7
    • +2
    /src/main/webapp/requisition-initiate/period.factory.spec.js
6:29 pm

Paweł Gesek

OLMIS-2006: Mock url factory during test

Thanks do this, all requests will go do the $httpBackend, even

when running with a server url param.

Options
    • -4
    • +10
    /src/main/webapp/report/report.service.spec.js
5:09 pm

Paweł Gesek

OLMIS-2006: Added a spec for the report service

Options
    • -0
    • +133
    /src/main/webapp/report/report.service.spec.js
3:36 pm

Paweł Gesek

OLMIS-2006: Fix JSDoc parents

Options
    • -4
    • +4
    /src/main/webapp/report/report-generate.controller.js
    • -1
    • +1
    /src/main/webapp/report/report.factory.js
3:25 pm

Paweł Gesek

OLMIS-2006: Added jsdocs to the report module

Options
    • -1
    • +1
    /src/main/webapp/admin-template-list/program-administration-list.controller.js
    • -0
    • +50
    /src/main/webapp/report/report-generate.controller.js
    • -1
    • +11
    /src/main/webapp/report/report-list.controller.js
    • -0
    • +69
    /src/main/webapp/report/report.factory.js
    • -0
    • +37
    /src/main/webapp/report/report.service.js
Tuesday 28 Feb 2017
2:31 pm

Paweł Gesek

OLMIS-2018: Fixed test case names

Options
    • -6
    • +6
    /src/main/webapp/requisition/requisition.spec.js
2:27 pm

Paweł Gesek

OLMIS-1769: Fix default report format selection

Options
    • -0
    • +1
    /src/main/webapp/report/report-generate.controller.js
    • -1
    • +1
    /src/main/webapp/report/report-generate.html
2:19 pm

Paweł Gesek

OLMIS-2018: Display approved quantity & remarks columns for IN_APPROVAL rnr

Options
    • -1
    • +3
    /src/main/webapp/requisition-initiate/requisition-initiate.controller.js
    • -1
    • +1
    /src/main/webapp/requisition-template/requisition-column.js
    • -23
    • +15
    /src/main/webapp/requisition-template/requisition-column.spec.js
    • -0
    • +17
    /src/main/webapp/requisition/requisition.js
    • -0
    • +32
    /src/main/webapp/requisition/requisition.spec.js
12:45 pm

Paweł Gesek

OLMIS-1769: Make PDF the default type

Options
    • -1
    • +1
    /src/main/webapp/report/report-generate.html
Thursday 23 Feb 2017
4:29 pm

Paweł Gesek

Merge pull request #3 from as588/patch-1

Updates for typos and grammar

Options
9:06 am

Paweł Gesek

OLMIS-1686: Deleting LICENSE-HEADER

The one from dev-ui is used by default.

Options
    • -14
    • +0
    /LICENSE-HEADER
Tuesday 21 Feb 2017
1:54 pm

Paweł Gesek

OLMIS-1686: Updated index.html copyright header

Options
    • -4
    • +8
    /src/main/webapp/index.html
1:49 pm

Paweł Gesek

OLMIS-1686: Updated copyright in js files and added LICENSE-HEADER

Options
    • -0
    • +15
    /Gruntfile.js
    • -0
    • +14
    /LICENSE-HEADER
    • -0
    • +15
    /consul/registration.js
    • -0
    • +15
    /karma.config.js
    • -0
    • +15
    /src/main/webapp/admin-template-list/admin-template-list.module.js
    • -4
    • +10
    /src/main/webapp/admin-template-list/admin-template-list.routes.js
    • -4
    • +10
    /src/main/webapp/admin-template-list/program-administration-list.controller.js
    • -5
    • +11
    /src/main/webapp/admin-template-list/program.factory.js
    • -5
    • +11
    /src/main/webapp/admin-template-list/program.factory.spec.js
    • -0
    • +15
    /src/main/webapp/admin-template/admin-template.module.js
    • -0
    • +15
    /src/main/webapp/admin-template/alph-numeric-regex.constant.js
    • -4
    • +10
    /src/main/webapp/admin-template/disable-drag.directive.js
    • -0
    • +15
    /src/main/webapp/admin-template/max-column-description-length.constant.js
    • -0
    • +15
    /src/main/webapp/admin-template/order-object-by.filter.js
    • -0
    • +15
    /src/main/webapp/admin-template/requisition-template-admin.controller.js
  16. … 300 more files in changeset.
Thursday 09 Feb 2017
5:06 pm

Paweł Gesek

OLMIS-1661: Added gzip compression to nginx

Set level to 5, since it seems the most optimal overall.

Gzipping css, js and html.

Options
    • -0
    • +4
    /nginx.conf
Tuesday 07 Feb 2017
2:11 pm

Paweł Gesek

OLMIS-1648: Fixed total adjustments recalculations

Used ng-changed to recalculate every time we someone changes a value

in the adjustment list.

Options
    • -0
    • +1
    /src/main/webapp/requisition-losses-and-adjustments/losses-and-adjustments-modal.html
    • -2
    • +7
    /src/main/webapp/requisition-losses-and-adjustments/losses-and-adjustments.controller.js
    • -0
    • +7
    /src/main/webapp/requisition-losses-and-adjustments/losses-and-adjustments.controller.spec.js
Monday 06 Feb 2017
4:01 pm

Paweł Gesek

OLMIS-880: Offline requisition conflict handling

* Made requisition pass response to failure handlers

* Reload the state of requisition view if the error is 409

Options
    • -1
    • +2
    /src/main/resources/messages_en.json
    • -1
    • +1
    /src/main/webapp/openlmis-local-storage/local-storage.factory.js
    • -7
    • +14
    /src/main/webapp/requisition-view/requisition-view.controller.js
    • -4
    • +65
    /src/main/webapp/requisition-view/requisition-view.controller.spec.js
    • -3
    • +3
    /src/main/webapp/requisition/requisition.js
Tuesday 20 Dec 2016
9:46 am

Paweł Gesek

Fix spelling errors

Options
    • -3
    • +3
    /src/main/webapp/requisitions/template/template-admin.controller.js
    • -1
    • +1
    /src/main/webapp/requisitions/template/template-columns.filter.js
    • -3
    • +3
    /src/main/webapp/requisitions/template/template.factory.js
    • -2
    • +2
    /src/main/webapp/requisitions/template/template.factory.spec.js
Monday 19 Dec 2016
7:03 pm

Paweł Gesek

OLMIS-933: Fix issues with template dependencies

Ok, so I've done a bit of changing. In short, there were problems with

how we did our validations, hence I removed some and changed others. The

problem was that we used the dependency field in requisition-column

for more things that it should be used for (in v2 some validation are

not generic and only apply to select fields). I am currently using it

to mark fields as dependent in each others calculations. I believe however,

that these definitions should probably be moved to the back end in the end.

These are my changes:

* I changed that a field cannot depend on a different calculated field.

This is required, especially since we use the dependency array to

trigger recalculations on the product grid. The current solution

might seem a bit complex, since it is a recursion, it is however

a solution that should work with anything we come up with regarding the

template.

* I removed the validation that a user input field must be displayed. This

was not the case in v2 except for two fields: stockOnHand and

totalConsumedQuantity. This validation is currently missing.

* I removed the validation that all dependent fields must be visisble

for a field to be visisble. This was only the case requestedQuantity

and requestedQuantityExplanation in v2. This validation is missing.

* I defined the dependencies for totalConsumedQuantity. Up to this point,

since the field had no dependencies, it wouldn't auto refresh in the

product grid at all.Fixed template validation

Options
    • -3
    • +8
    /src/main/webapp/requisitions/requisition-column.js
    • -12
    • +10
    /src/main/webapp/requisitions/template/template-admin.controller.js
    • -9
    • +30
    /src/main/webapp/requisitions/template/template-admin.controller.spec.js
    • -10
    • +65
    /src/main/webapp/requisitions/template/template.factory.js
    • -30
    • +152
    /src/main/webapp/requisitions/template/template.factory.spec.js
Saturday 17 Dec 2016
10:51 am

Paweł Gesek

OLMIS-933: Declared dependencies for total cost

Required to trigger calculations

Options
    • -0
    • +4
    /src/main/webapp/requisitions/requisition-column.js
Friday 16 Dec 2016
2:46 pm

Paweł Gesek

OLMIS-933: Fixed ngDoc for calculation function

Options
    • -3
    • +2
    /src/main/webapp/requisitions/requisition/calculation.factory.js
2:40 pm

Paweł Gesek

OLMIS-933: Added total cost calculations

Options
    • -1
    • +3
    /src/main/webapp/requisitions/columns.constant.js
    • -2
    • +30
    /src/main/webapp/requisitions/requisition/calculation.factory.js
    • -0
    • +24
    /src/main/webapp/requisitions/requisition/calculation.factory.spec.js
Friday 18 Nov 2016
4:39 pm

Paweł Gesek

OLMIS-1341: Move templates back to olmis-core

Core is available for all other modules, should solve

test issues.

Options
    • -1
    • +1
    /Gruntfile.js
4:15 pm

Paweł Gesek

OLMIS-1341: Fixed tokens being appended to templates

I've moved the templates to the openlmis top module, which

made most sense. Thanks to this tests started to fail - I figured

out the issue was with tokens being appended to .html template calls.

This a last ditch effort fix, so it might not be perfect.

If this won't fix the problem, I'm reverting the whole forsaken thing.

Options
    • -1
    • +1
    /Gruntfile.js
    • -1
    • +3
    /src/main/webapp/public/auth/auth-interceptor-http.js
    • -8
    • +2
    /src/main/webapp/public/auth/auth-interceptor.spec.js
1:02 pm

Paweł Gesek

Revert "Revert "OLMIS-1341: Pre-cache all HTML templates and partials""

This reverts commit ebf9ef8fb8e2b46d9f25b8a91c0936fa8f1a3761.

Options
    • -0
    • +1
    /.gitignore
    • -2
    • +13
    /Gruntfile.js
    • -9
    • +2
    /karma.config.js
    • -1
    • +1
    /package.json
    • -1
    • +0
    /src/main/webapp/public/auth/auth-interceptor.spec.js
    • -1
    • +0
    /src/main/webapp/public/auth/login-controller.spec.js
    • -1
    • +1
    /src/main/webapp/public/dashboard/header.html
    • -1
    • +1
    /src/main/webapp/public/requisitions/init-rnr-controller.js