Clone
 

chongsun ahn <cahn922@yahoo.com> in openlmis-fulfillment

OLMIS-4500 Fix Sonar issues

OLMIS-4500 Split huge requests to other services into smaller chunks

Just like OLMIS-4335 and OLMIS-4368.

    • -0
    • +140
    /src/main/java/org/openlmis/fulfillment/util/Merger.java
  1. … 7 more files in changeset.
OLMIS-4380 Check for null before setting update details

Since update details are not required.

OLMIS-4274 Improve performance on more migrations

Instead of doing several updates, create a new temp table and copy data over. See https://dba.stackexchange.com/questions/52517/best-way-to-populate-a-new-column-in-a-large-table/52531#52531 . Did this for order_line_items and proofs_of_delivery. Also for some reason orderableid in order line items was nullable--fixed.

    • -18
    • +29
    /src/main/resources/db/migration/20180202092754358__modify_pod_schema_and_update_relation_between_order_and_pod.sql
OLMIS-4274 Improve performance of migrations

Instead of doing several updates, create a new temp table and copy data over. See https://dba.stackexchange.com/questions/52517/best-way-to-populate-a-new-column-in-a-large-table/52531#52531 . Also fix an update default status that does not seem to be joining to the proper table.

    • -1
    • +2
    /src/main/resources/db/migration/20180202092754358__modify_pod_schema_and_update_relation_between_order_and_pod.sql
OLMIS-4274 Move add orderableid column to its own migration

To see if there are performance issues with the existing migration and in preparation of improving performance of this migration.

OLMIS-4237 Fix faulty migration

POD line items table added orderableId column and made it not nullable, but did not provide data migration to enter orderableId from existing data.

OLMIS-3463 Add ERD generate script for service

Each service should be in charge of its own ERD generation. Remove the external port number, as it’s not necessary anymore and it could conflict with other services’ ERD generation jobs.

Move back to snapshot

OLMIS-3457 Release RC1 of Fulfillment 6.1.0

Add link to db container

Some integration test introduced by pull request merge needs the db container as well.

Add link to log container

Some integration test introduced by pull request merge needs the log container, since it is sending log statements to it.

OLMIS-3116 Change user home facility from Facility DTO to UUID

To reflect change in reference data.

Moving service to snapshot of next release

For future development work. Since it is expected that the next release of this component will likely have more than just bug fixes, moving to 3.1.0-SNAPSHOT, rather than 3.0.2-SNAPSHOT.

Update service version from snapshot to 3.0.1

For 3.0.1 release of component.

Create CHANGELOG file for 3.0.0 and 3.0.1 releases

To show the changes since 3.0.0.

Add IN_APPROVAL to list of statuses

To match requisition statuses.

Moving service to snapshot of next release

For future development work.

Fix bug in Sonar build process

Add a clean task before sonarqube task, which runs a full build anyways.

Update service version from snapshot to 3.0.0

For 3.0.0 release.

Update service util from snapshot to release version

For 3.0.0 release.

OLMIS-1933 Change infrastructure/dev images from latest to 1

Moving away from latest to versioned image.

OLMIS-1933 Change postgres image from latest to 9.4

Moving away from latest to versioned image.

OLMIS-1741 Rename blue to reference distribution

Blue is being deprecated in favor of reference distribution/ref distro.

Merge branch 'feature/OLMIS-1726-rename-months'

OLMIS-1726 Update maxStock and minStock names to include periods

Update maxStock to maxPeriodsOfStock and minStock to minPeriodsOfStock. It's more descriptive and less confusing for developers.

OLMIS-1566 Update order search endpoint not to require warehouse

Do not need supplying facility to do the view order check since we are automatically filtering the orders by right anyways. Need to check PODS_MANAGE right in addition to ORDERS_VIEW right, since the user could have either one to get the list of orders. No need for 403 Forbidden because if the user does not have permission, the orders list should be empty.

    • -6
    • +2
    /src/main/resources/api-definition.yaml
OLMIS-1726 Rename references of months

Done in the code. No changes necessary to JSON schema or demo data.

Rename packToShip to packsToShip

Rename typo; should be packs to ship.

    • -2
    • +2
    /demo-data/fulfillment.proof_of_delivery_line_items.json
OLMIS-1497 Do not get access token from request for external service calls

This service, when calling another service, should not use the access token in the request, since it may not be a service-level token. Instead it should get one from the auth service every time.