openlmis-fulfillment

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done.

Done.

Yes

Yes

Should I do this?

Should I do this?

That would probably make sense, in case someone updates the wiremock version in the future

That would probably make sense, in case someone updates the wiremock version in the future

Referencedata was the only service which has used wire mock in the version 2.22.0. In 1.58 the problem doesn't occur. The only thing that we could do is to move the wire mock to the testCompile sec...

Referencedata was the only service which has used wire mock in the version 2.22.0. In 1.58 the problem doesn't occur. The only thing that we could do is to move the wire mock to the testCompile section in dependencies (in fulfillment, stockmanagement, and report).

Good catch. Did you manage to check whether the same problem exists in other services too?

Good catch. Did you manage to check whether the same problem exists in other services too?

OLMIS-6564: Fixed responses compression in the referencedata service
OLMIS-6564: Fixed responses compression in the referencedata service
OLMIS-6494 Updated fulfillment reports to display the correct version of an orderable
OLMIS-6494 Updated fulfillment reports to display the correct version of an orderable
OLMIS-6479 Fix search PoD by Order ID when PoD has no line items
OLMIS-6479 Fix search PoD by Order ID when PoD has no line items
Thanks for being vigilant, I changed this for debugging process. Now it's back as it was.

Thanks for being vigilant, I changed this for debugging process. Now it's back as it was.

done

done

Probably we can remove this comment.

Probably we can remove this comment.

Why we changed this?

Why we changed this?

Yes, there is only one, I just forgot to delete it from this review.

Yes, there is only one, I just forgot to delete it from this review.

Probably we can use a static variable ORDERABLE here.

Probably we can use a static variable ORDERABLE here.