openlmis-requisition-ui

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6037: Standardize build statuses for all our Jenkins jobs
OLMIS-6037: Standardize build statuses for all our Jenkins jobs
OLMIS-6234: Fixed issue with error indicator not working on the non full supply tab of the requisition...
OLMIS-6234: Fixed issue with error indicator not working on the non full supply tab of the requisition...
It is undefined by default but reload takes previously used params and causes that requisition is defined.

It is undefined by default but reload takes previously used params and causes that requisition is defined.

Do we need this line? Isn't undefined the default value for omitted properties?

Do we need this line? Isn't undefined the default value for omitted properties?

Because of the previous comment. Also, it's checked in the routes test.

Because of the previous comment. Also, it's checked in the routes test.

Klaudia Pałkowska why the test hasn't be moved?

Klaudia Pałkowska why the test hasn't be moved?

I believe this belongs in the requisition-view.routes specs.

I believe this belongs in the requisition-view.routes specs.

When?

When?

Actually, the ternary operator was the correct approach here.

Actually, the ternary operator was the correct approach here.

OLMIS-6125: Display message in submitted/authorized column on approve screen for partner requisitions
OLMIS-6125: Display message in submitted/authorized column on approve screen for partner requisitions
Sure, done.

Sure, done.

can we change ?: to ||?

can we change ?: to ||?

OLMIS-6077: Fixed issue with additional call to retrieve requisition after initiate.
OLMIS-6077: Fixed issue with additional call to retrieve requisition after initiate.
Feel free to close the review.

Feel free to close the review.

OLMIS-6071: Refactored requisition-approval.routes.spec.js
OLMIS-6071: Refactored requisition-approval.routes.spec.js
OLMIS-6071: Made Approve Requisitions screen accessible to partner users
OLMIS-6071: Made Approve Requisitions screen accessible to partner users
Already implemented as instructed here on commit OLMIS-5959: Enable facility type button and set facility type input required (https://github.com/OpenLMIS/openlmis-requisition-ui/commit/1446f6a3209...

Already implemented as instructed here on commit OLMIS-5959: Enable facility type button and set facility type input required (https://github.com/OpenLMIS/openlmis-requisition-ui/commit/1446f6a3209ba7245e04f5adc85d4d4258917b52)