openlmis-report

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Release report service 1.2.2-RC1

I will close this review and open another one

I will close this review and open another one

You make a very good point, when we started the plan was to implement this in the Core project but later on, Wes suggested we should first focus on the TZ requirment, so I accept that maybe this sh...

You make a very good point, when we started the plan was to implement this in the Core project but later on, Wes suggested we should first focus on the TZ requirment, so I accept that maybe this should be moved to TZ common repository

Ian The report that you are picking up seems to fully assume the application is sending google analytics data exactly like eLMIS (v2) is sending data to google analytics. For example, eLMIS is send...

Ian
The report that you are picking up seems to fully assume the application is sending google analytics data exactly like eLMIS (v2) is sending data to google analytics. For example, eLMIS is sending the user id as a custom variable. Is OpenLMIS v3 sending the userID the same way? Will this work?

Ian Is this feature specific to Tanzania? or is it something that is needed in the OpenLMIS report? If it is Tanzania Specific, may be committing it in the generic https://gitlab.com/openlmis/tz-op...

Ian Is this feature specific to Tanzania? or is it something that is needed in the OpenLMIS report?
If it is Tanzania Specific, may be committing it in the generic https://gitlab.com/openlmis/tz-openlmis-commons tanzania repository makes sense?

Chongsun Ahn Josh Zamor Thoughts?

Is this a hard coded Application Name? would it make sense to make it configuarable?

Is this a hard coded Application Name? would it make sense to make it configuarable?

This file looks to contain credentials. Checking in private key in a public repository is generally discouraged.

This file looks to contain credentials. Checking in private key in a public repository is generally discouraged.

TZUP-117 Create backend to extract number of users who logged in OpenLMIS
TZUP-117 Create backend to extract number of users who logged in OpenLMIS
Using user-session information from GA to create API that will be used to create the report

Using user-session information from GA to create API that will be used to create the report

OLMIS-6983: Sonar analysis and build reference ui runs only for snapshots
OLMIS-6983: Sonar analysis and build reference ui runs only for snapshots
OLMIS-6983: Sonar analysis and contract tests runs only for snapshots

- removed checking branch name

OLMIS-6983: Sonar analysis and contract tests run only for snapshots
OLMIS-6983: Sonar analysis and contract tests run only for snapshots
OLMIS-6983: Sonar analysis and contract tests run only for snapshots

Bumped version to 1.2.2-SNAPSHOT

Release 1.2.1

OLMIS-6887: Changed some unit tests to be integration tests

OLMIS-6887: Improved code coverage

OLMIS-6887: Added tests for refactored code

OLMIS-6887: Jasper Reports can't be generated more than 10 times in a row
OLMIS-6887: Jasper Reports can't be generated more than 10 times in a row
OLMIS-6887: Added try-with-resources for connection with database while printing the jasper reports

    • -0
    • +7
    /src/test/resources/empty-report.jrxml
Bumped version to 1.2.1-SNAPSHOT

Release 1.2.0