openlmis-referencedata

Clone Tools

Stats

Commits this week: 2
Total Committers: 59
Last Commit:
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Aug
6:07 am

Paulina Mironiuk

Tuesday 20 Aug
2:24 pm

Sebastian Brudziński

1:27 pm

Paweł Pinker

Refactored tests not to send another request to check Last-Modified Header's presence

Options
    • -51
    • +20
    /src/integration-test/java/org/openlmis/referencedata/web/OrderableControllerIntegrationTest.java
11:23 am

Sebastian Brudziński

Let's not send another request just to verify the headers. We can re-use response from the previous call.

Let's not send another request just to verify the headers. We can re-use response from the previous call.

10:40 am

Paweł Pinker

Checking Last-Modified Header moved to existing tests from a separate one

Options
    • -34
    • +38
    /src/integration-test/java/org/openlmis/referencedata/web/OrderableControllerIntegrationTest.java
8:26 am

Sebastian Brudziński

Let's not introduce another test just to verify the header. We can do the additional check in existing tests.

Let's not introduce another test just to verify the header. We can do the additional check in existing tests.

Wednesday 14 Aug
10:03 am

Paweł Pinker

OLMIS-6485 Added new test to check Last-Modified Header's presence in PUT /orderables responses and improved exisiting onese

Options
    • -0
    • +1
    /CHANGELOG.md
    • -42
    • +58
    /src/integration-test/java/org/openlmis/referencedata/web/OrderableControllerIntegrationTest.java
    • -3
    • +8
    /src/main/java/org/openlmis/referencedata/web/OrderableController.java
Tuesday 13 Aug
2:18 pm

Paweł Pinker

I debugged it and I can confirm that. I removed that line from those tests and I'm looking for new way to test it - either inside those methods or separately.

I debugged it and I can confirm that. I removed that line from those tests and I'm looking for new way to test it - either inside those methods or separately.

10:58 am

Paulina Mironiuk

Update Changelog file, please.

Update Changelog file, please.

10:17 am

Sebastian Brudziński

Since you have added profiler - let's add measurements for each important step - validate, build orderable, save,

Since you have added profiler - let's add measurements for each important step - validate, build orderable, save,

10:16 am

Sebastian Brudziński

This block is repeated 3 times. Extract it to a private method.

This block is repeated 3 times. Extract it to a private method.

10:16 am

Sebastian Brudziński

This likely has the potential to fail randomly. Please debug this test to verify.

This likely has the potential to fail randomly. Please debug this test to verify.

10:15 am

Sebastian Brudziński

10:07 am

Paweł Pinker

OLMIS-6485 Added Last-Modified Header to the POST and PUT /orderables endpoints
OLMIS-6485 Added Last-Modified Header to the POST and PUT /orderables endpoints
9:59 am

Paweł Pinker

OLMIS-6485 Added Last-Modified Header to the POST and PUT /orderables endpoints

Options
    • -13
    • +54
    /src/integration-test/java/org/openlmis/referencedata/web/OrderableControllerIntegrationTest.java
    • -4
    • +18
    /src/main/java/org/openlmis/referencedata/web/OrderableController.java
7:17 am

Paulina Mironiuk

7:14 am

Klaudia Pałkowska and Łukasz Lewczyński

6:40 am

Paulina Mironiuk

OLMIS-6476 Fixed getting paginated orderables and added sorting by product name
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name
6:22 am

Paulina Mironiuk

OLMIS-6476 Fixed getting paginated orderables and added sorting by product name

Options
    • -1
    • +45
    /src/integration-test/java/org/openlmis/referencedata/repository/OrderableRepositoryIntegrationTest.java
    • -16
    • +0
    /src/main/java/org/openlmis/referencedata/repository/OrderableRepository.java
    • -28
    • +41
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/OrderableRepositoryImpl.java
    • -1
    • +1
    /src/main/java/org/openlmis/referencedata/service/OrderableService.java
    • -4
    • +4
    /src/test/java/org/openlmis/referencedata/service/OrderableServiceTest.java
Friday 09 Aug
10:46 am

Paulina Mironiuk

10:23 am

Klaudia Pałkowska and Łukasz Lewczyński

9:31 am

Paulina Mironiuk

OLMIS-6476 Fixed query for finding orderable with latest modified date with pagination

Options
    • -4
    • +7
    /src/main/java/org/openlmis/referencedata/repository/OrderableRepository.java
6:45 am

Paulina Mironiuk

done

done

6:43 am

Paulina Mironiuk

OLMIS-6476 Improved integration tests for orderable repository

Options
    • -0
    • +9
    /src/integration-test/java/org/openlmis/referencedata/repository/OrderableRepositoryIntegrationTest.java
6:08 am

Łukasz Lewczyński

should we update entries in database after setting last updated field?

should we update entries in database after setting last updated field?

6:00 am

Paulina Mironiuk

OLMIS-6476 Added support for If-Modified-Since header to get and search Orderables
OLMIS-6476 Added support for If-Modified-Since header to get and search Orderables
5:53 am

Paulina Mironiuk

OLMIS-6476 Added support for If-Modified-Since header to get and search Orderables

Options
    • -0
    • +1
    /CHANGELOG.md
    • -1
    • +63
    /src/integration-test/java/org/openlmis/referencedata/repository/OrderableRepositoryIntegrationTest.java
    • -1
    • +142
    /src/integration-test/java/org/openlmis/referencedata/web/OrderableControllerIntegrationTest.java
    • -0
    • +33
    /src/main/java/org/openlmis/referencedata/repository/OrderableRepository.java
    • -0
    • +1
    /src/main/java/org/openlmis/referencedata/repository/RepositoryConstants.java
    • -0
    • +4
    /src/main/java/org/openlmis/referencedata/repository/custom/OrderableRepositoryCustom.java
    • -2
    • +43
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/OrderableRepositoryImpl.java
    • -0
    • +35
    /src/main/java/org/openlmis/referencedata/service/OrderableService.java
    • -25
    • +67
    /src/main/java/org/openlmis/referencedata/web/OrderableController.java
    • -0
    • +4
    /src/main/resources/api-definition.yaml
    • -0
    • +99
    /src/test/java/org/openlmis/referencedata/service/OrderableServiceTest.java
Wednesday 07 Aug
9:06 am

Oskar Hinc <oskarhinc@gmail.com>

OLMIS-6474: Extracted fetching commodity types and trade items above the loop

* OLMIS-6474: Extracted fetching commodity types and trade items above the loop

* PIMS-6474: Changed the changelog entry

Options
    • -0
    • +1
    /CHANGELOG.md
    • -2
    • +5
    /src/integration-test/java/org/openlmis/referencedata/web/OrderableFulfillControllerIntegrationTest.java
    • -3
    • +18
    /src/main/java/org/openlmis/referencedata/web/OrderableFulfillController.java
    • -11
    • +10
    /src/main/java/org/openlmis/referencedata/web/OrderableFulfillFactory.java
    • -17
    • +10
    /src/test/java/org/openlmis/referencedata/web/OrderableFulfillFactoryTest.java
Tuesday 06 Aug
9:10 pm

Josh Zamor

OLMIS-6495, output junit report for performance tests

Options
    • -0
    • +3
    /performance/config.yml
9:22 am

Sebastian Brudziński