openlmis-referencedata

Clone Tools

Stats

Commits this week: 6
Total Committers: 59
Last Commit:
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Sep
7:55 am

Mateusz Wedeł

OLMIS-6568 Fix file.format.incorrect message key in messages_en.

Options
    • -1
    • +1
    /src/main/resources/messages_en.properties
7:53 am

Sebastian Brudziński

OLMIS-6450 Performance improvements and adjusting tests thresholds for FTAPs
OLMIS-6450 Performance improvements and adjusting tests thresholds for FTAPs
Thursday 12 Sep
2:31 pm

Klaudia Pałkowska

We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

12:58 pm

Klaudia Pałkowska

Please remove one of those changelogs (or merge them somehow).

Please remove one of those changelogs (or merge them somehow).

11:05 am

Paweł Pinker

11:04 am

Paweł Pinker

Extracting those lines to a separate method will cause "The class has too many methods, consider refactoring it" error while building project in Gradle.

Extracting those lines to a separate method will cause "The class has too many methods, consider refactoring it" error while building project in Gradle.

11:03 am

Paweł Pinker

OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup
OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup
11:00 am

Paweł Pinker

OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup

Options
    • -1
    • +2
    /CHANGELOG.md
    • -39
    • +136
    /src/integration-test/java/org/openlmis/referencedata/web/SupervisoryNodeControllerIntegrationTest.java
    • -0
    • +26
    /src/main/java/org/openlmis/referencedata/web/SupervisoryNodeController.java
9:34 am

Sebastian Brudziński

OLMIS-6450 Adjust performance tests thresholds fo FTAPs

Options
    • -2
    • +2
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
Wednesday 11 Sep
4:11 pm

Sebastian Brudziński

OLMIS-6450 Partition HQL queries to avoid StackOverflow

Hibernate is running into issues when a huge number of composite identities

is passed in the where clause. This wasn't a problem with native query, but

native query is slower and introduces n+1 loading problem. We partition

the identities to 3000 per chunk and merge the results.

Options
    • -1
    • +7
    /src/main/java/org/openlmis/referencedata/domain/VersionIdentity.java
    • -22
    • +30
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/FacilityTypeApprovedProductRepositoryImpl.java
Tuesday 10 Sep
2:23 pm

Paweł Pinker

Revert "OLMIS-6470: Testing if creating and updating a Supervidory Node with a Requisition Group works properly"

This reverts commit b84b42a9a76ba46a3ec688a9657932a95cac6fd5.

Options
    • -41
    • +0
    /src/main/java/org/openlmis/referencedata/web/SupervisoryNodeController.java
1:41 pm

Paweł Pinker

OLMIS-6470: Testing if creating and updating a Supervidory Node with a Requisition Group works properly

Options
    • -0
    • +41
    /src/main/java/org/openlmis/referencedata/web/SupervisoryNodeController.java
1:20 pm

Klaudia Pałkowska

1:07 pm

Paweł Pinker and Aleksandra Sołtys

12:06 pm

Klaudia Pałkowska

Friday 06 Sep
9:35 am

Paulina Mironiuk

8:50 am

Paweł Pinker

Thursday 05 Sep
8:37 am

Aleksandra Sołtys , Paulina Mironiuk and Klaudia Pałkowska

8:02 am

Paweł Pinker

OLMIS-6470: Improved getUpdatedSupervisoryNode method - better log message and only one call

Options
    • -3
    • +3
    /src/main/java/org/openlmis/referencedata/web/RequisitionGroupController.java
7:24 am

Paulina Mironiuk

Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

7:13 am

Klaudia Pałkowska

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

Wednesday 04 Sep
3:37 pm

Paweł Pinker

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am no...

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am not mistaken. The SN presence is validated before that and is indeed throwing ValidationMessageExeption if needed. Maybe I should just correct the log message as it's indeed confusing now?

9:28 am

Sebastian Brudziński

OLMIS-6450 Retrieve last modified date only when needed

This means removing the response header with last modified date in search

and querying for it only when the if-modified-since header was provided

Options
    • -6
    • +6
    /src/integration-test/java/org/openlmis/referencedata/web/OrderableControllerIntegrationTest.java
    • -18
    • +16
    /src/main/java/org/openlmis/referencedata/web/OrderableController.java
Tuesday 03 Sep
3:09 pm

Sebastian Brudziński

OLMIS-6450 Include ProgramOrderable and Programs in select query for orderables

Options
    • -1
    • +1
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/OrderableRepositoryImpl.java
11:53 am

Sebastian Brudziński

OLMIS-6450 Avoid n+1 queries in orderables fetch

Including all necessary data in the native query

so that Hibernate doesn't fetch it 1 by 1.

Options
    • -6
    • +22
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/OrderableRepositoryImpl.java
6:02 am

Paulina Mironiuk

I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

Monday 02 Sep
1:29 pm

Sebastian Brudziński

OLMIS-6450 Attempt to improve performance of FTAP fetch

Attempting to avoid n+1 queries by joining necessary tables

in one query for Hibernate.

Options
    • -2
    • +6
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/FacilityTypeApprovedProductRepositoryImpl.java
    • -1
    • +0
    /src/main/java/org/openlmis/referencedata/web/FacilityController.java
12:33 pm

Paweł Pinker

12:32 pm

Paweł Pinker

OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
12:18 pm

Paweł Pinker

Merge branch 'master' of https://github.com/OpenLMIS/openlmis-referencedata

Options