tz-equipment

Clone Tools

Stats

Commits this week: 0
Total Committers: 45
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 17 Apr
11:46 am

hassan

11:40 am

Boniface Chacha

11:38 am

Boniface Chacha

11:02 am

hassan

10:46 am

hassan

10:44 am

hassan

10:40 am

hassan

I added them in EquipmentMaintenanceRequestReasonControllerTest.java class.. eg. search, shouldGetAllMaintenanceRequestReason function. please load the latested files Boniface Chacha

I added them in EquipmentMaintenanceRequestReasonControllerTest.java class.. eg. search, shouldGetAllMaintenanceRequestReason function. please load the latested files Boniface Chacha

10:37 am

Boniface Chacha

10:37 am

Boniface Chacha

10:33 am

hassan

Boniface Chacha Just added more test cases kindly review

Boniface Chacha Just added more test cases kindly review

9:29 am

hassan

9:28 am

hassan

LGTM

LGTM

9:24 am

Boniface Chacha

Since you are using this similar table on the logic for a different feature, i advise we open a different ticket for it to make changes on both cases

Since you are using this similar table on the logic for a different feature, i advise we open a different ticket for it to make changes on both cases

9:23 am

Boniface Chacha

This is a join table so no primary keys here

This is a join table so no primary keys here

9:17 am

Boniface Chacha

Let us add tests for this repository

Let us add tests for this repository

9:13 am

Boniface Chacha

This repository class does not have integration tests

This repository class does not have integration tests

9:13 am

Boniface Chacha

I only see tests for 201, we should add tests for other codes 403 and 401 as you described in the api-definintion.yml

I only see tests for 201, we should add tests for other codes 403 and 401 as you described in the api-definintion.yml

9:09 am

Boniface Chacha

9:09 am

Boniface Chacha

LGTM

LGTM

8:48 am

hassan

Is it okay to add primary key to vendor associate users table i.e Id ?

Is it okay to add primary key to vendor associate users table i.e Id ?

8:46 am

hassan

Just rename the table name to plural

Just rename the table name to plural

Saturday 15 Apr
4:52 pm

hassan

TZUP-81:-Added code for equipment maintenance findings screen
TZUP-81:-Added code for equipment maintenance findings screen
Thursday 13 Apr
10:55 am

hassan

TZUP-78:-Added backend API to request equipment Maintenance to Vendor
TZUP-78:-Added backend API to request equipment Maintenance to Vendor
Wednesday 12 Apr
6:44 pm

hassan

TZUP-352:-Added API to manage Equipment maintenance reasons
TZUP-352:-Added API to manage Equipment maintenance reasons
4:47 pm

Josh Zamor

4:47 pm

Josh Zamor

LGTM

LGTM

4:47 pm

Josh Zamor

Okay, makes sense.

Okay, makes sense.

10:57 am

Boniface Chacha

The refactoring will introduce changes to alot of other classes not related to this review. So i will do it on a separate one

The refactoring will introduce changes to alot of other classes not related to this review. So i will do it on a separate one

3:07 am

Josh Zamor

3:07 am

Josh Zamor

LGTM

LGTM