openlmis-contract-tests

Clone Tools

Stats

Commits this week: 0
Total Committers: 45
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Aug 2021
10:56 am

Magdalena Toczek

Wednesday 21 Jul 2021
9:57 am

Aleksandra Sołtys

Tuesday 20 Jul 2021
9:13 am

Magdalena Toczek

OLMIS-7345: Updated CHANGELOG.md
OLMIS-7345: Updated CHANGELOG.md
Friday 09 Apr 2021
5:57 am

Klaudia Pałkowska

5:27 am

Aleksandra Sołtys

Friday 02 Apr 2021
12:10 pm

Sebastian Brudziński

Thursday 01 Apr 2021
12:49 pm

Klaudia Pałkowska

OLMIS-7219: Updated POST /order and /orders/batch to return existing orders if already created
OLMIS-7219: Updated POST /order and /orders/batch to return existing orders if already created
10:05 am

Klaudia Pałkowska

NullPointer is thrown in that case.

NullPointer is thrown in that case.

9:19 am

Sebastian Brudziński

Let's not change behavior for this endpoint

Let's not change behavior for this endpoint

9:18 am

Sebastian Brudziński

there's no "requisition" concept in fulfillment - let's stick to external id

there's no "requisition" concept in fulfillment - let's stick to external id

9:17 am

Sebastian Brudziński

9.0.0 - major version needs to be updated in case of breaking changes

9.0.0 - major version needs to be updated in case of breaking changes

9:16 am

Sebastian Brudziński

Actually, let's not change this behavior for POST /orders - it should still return 400 if the order already exists

Actually, let's not change this behavior for POST /orders - it should still return 400 if the order already exists

9:15 am

Sebastian Brudziński

Do we need this check? What happens if I try to find by null value?

Do we need this check? What happens if I try to find by null value?

Thursday 12 Nov 2020
8:05 am

Paulina Buzderewicz

Tuesday 10 Nov 2020
4:43 pm

Sebastian Brudziński and Klaudia Pałkowska

4:43 pm

Sebastian Brudziński

Looks good to me! I only noticed one typo - left a comment

Looks good to me! I only noticed one typo - left a comment

4:37 pm

Sebastian Brudziński

extensions

extensions

Monday 09 Nov 2020
1:26 pm

Sebastian Brudziński

As in MessageKeys - we should never copy other classes/resources from the main module in the extension. If those ever change in the stockmanagement - we break/hide it here.

As in MessageKeys - we should never copy other classes/resources from the main module in the extension. If those ever change in the stockmanagement - we break/hide it here.

1:25 pm

Sebastian Brudziński

The extension module should have access to the classes from the module it extends - we shouldn't be required to copy the classes we need

The extension module should have access to the classes from the module it extends - we shouldn't be required to copy the classes we need

1:24 pm

Sebastian Brudziński

General thought - looking at those tests, at the validators, and at this examplar in general, it's very difficult to find what's the difference between the original version and the extended version...

General thought - looking at those tests, at the validators, and at this examplar in general, it's very difficult to find what's the difference between the original version and the extended version. We should go ahead and completely change those 3 validators and their names.

Some ideas:
NoneValidator - an extension that demonstrates how to switch off one validator completely (it always passes)
OnlyLoggingValidator - an extension to a validator that only prints warning but doesn't fail validation - perhaps difficult to test
NoKitsValidator - a validator that prevents the use of kits - it always fails when kits are used

In general - avoid subtle changes, but demonstrate that you can completely alter the validator

1:20 pm

Paulina Buzderewicz

I was considering having only the messages which are used in the extension module. But eventually I thought that if there will be any other/more messages used then they would need to be added here ...

I was considering having only the messages which are used in the extension module. But eventually I thought that if there will be any other/more messages used then they would need to be added here each time.

1:19 pm

Paulina Buzderewicz

I was considering having only the messages which are used in the extension module. But eventually I thought that if there will be any other/more messages used then they would need to be added here ...

I was considering having only the messages which are used in the extension module. But eventually I thought that if there will be any other/more messages used then they would need to be added here each time.

1:12 pm

Sebastian Brudziński

Why do we need this whole file?

Why do we need this whole file?

1:11 pm

Sebastian Brudziński

Why do we need this whole file?

Why do we need this whole file?

1:00 pm

Paulina Buzderewicz

Thank you!

Thank you!

12:57 pm

Paulina Buzderewicz

I just took this pattern from Stock Management contract tests.

I just took this pattern from Stock Management contract tests.

12:53 pm

Klaudia Pałkowska

Good job https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

Good job

12:51 pm

Klaudia Pałkowska

Is there any reason why we decided to present the request as JSON instead of transforming it into a table?

Is there any reason why we decided to present the request as JSON instead of transforming it into a table?

11:40 am

Paulina Buzderewicz

OLMIS-6957: Added Contract test for Stock Management extension validators
OLMIS-6957: Added Contract test for Stock Management extension validators
Tuesday 31 Mar 2020
11:05 am

Klaudia Pałkowska