openlmis-referencedata

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint...
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint...
Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?

True. The method was refactored.

True. The method was refactored.

Why do we need this step if we are returning null anyways?

Why do we need this step if we are returning null anyways?

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

Is that still necessary?

Is that still necessary?

We should be using constants for all of the literals

We should be using constants for all of the literals

Unfortunately according to the documentation, CriteriaBuilder API doesn't support equals with ignore case

Unfortunately according to the documentation, CriteriaBuilder API doesn't support equals with ignore case

Yes, we can! https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/biggrin.gif

Yes, we can!

Can't we use the constant from the abstract class?

Can't we use the constant from the abstract class?

This is needed for yet another partition in retrieving FTAPs (line 146)

This is needed for yet another partition in retrieving FTAPs (line 146)

We should extract all of those literals as constants

We should extract all of those literals as constants

Also, +1 for splitting the common code to a separate class. Good job!

Also, +1 for splitting the common code to a separate class. Good job!

Instead of this essay can just say "Active flag of ProgramOrderables does no longer impact FTAP endpoints"

Instead of this essay can just say "Active flag of ProgramOrderables does no longer impact FTAP endpoints"

Don't mention requisitions in referencedata

Don't mention requisitions in referencedata

Drop "or not"

Drop "or not"

Can't we request a specific version?

Can't we request a specific version?

drop "or not"

drop "or not"

Why keep it here if we have that in the abstract class already?

Why keep it here if we have that in the abstract class already?

Let's not call this a util class if it's abstract. I'd go with IdentitiesSearchableRepository perhaps?

Let's not call this a util class if it's abstract. I'd go with IdentitiesSearchableRepository perhaps?