openlmis-referencedata

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6450 Performance improvements and adjusting tests thresholds for FTAPs
OLMIS-6450 Performance improvements and adjusting tests thresholds for FTAPs
We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

Please remove one of those changelogs (or merge them somehow).

Please remove one of those changelogs (or merge them somehow).

Extracting those lines to a separate method will cause "The class has too many methods, consider refactoring it" error while building project in Gradle.

Extracting those lines to a separate method will cause "The class has too many methods, consider refactoring it" error while building project in Gradle.

OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup
OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup
Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am no...

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am not mistaken. The SN presence is validated before that and is indeed throwing ValidationMessageExeption if needed. Maybe I should just correct the log message as it's indeed confusing now?

I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
OLMIS-6528 Fixed Internal Server Error after searching for orderables with null or malformed id
OLMIS-6528 Fixed Internal Server Error after searching for orderables with null or malformed id
I'm not sure if it should be primary (blue) button or not.

I'm not sure if it should be primary (blue) button or not.

OLMIS-6438: Fixed searching for orderables on modal and in API console
OLMIS-6438: Fixed searching for orderables on modal and in API console
Let's not send another request just to verify the headers. We can re-use response from the previous call.

Let's not send another request just to verify the headers. We can re-use response from the previous call.

Let's not introduce another test just to verify the header. We can do the additional check in existing tests.

Let's not introduce another test just to verify the header. We can do the additional check in existing tests.

I debugged it and I can confirm that. I removed that line from those tests and I'm looking for new way to test it - either inside those methods or separately.

I debugged it and I can confirm that. I removed that line from those tests and I'm looking for new way to test it - either inside those methods or separately.

Update Changelog file, please.

Update Changelog file, please.