Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
`Noted, you are right

`Noted, you are right

Yes i have created this ticket to include user identification on the information that OpenLMIS is sharing with GA (https://openlmis.atlassian.net/browse/TZUP-118)

Yes i have created this ticket to include user identification on the information that OpenLMIS is sharing with GA (https://openlmis.atlassian.net/browse/TZUP-118)

https://openlmis.atlassian.net/browse/TZUP-204

https://openlmis.atlassian.net/browse/TZUP-204

I assume you researched this a bit further. Is there any action item that you have to take to resolve the potential discrepancy?

I assume you researched this a bit further. Is there any action item that you have to take to resolve the potential discrepancy?

Great. Please post the link to the ticket when you create the ticket and I can resolve the comment.

Great. Please post the link to the ticket when you create the ticket and I can resolve the comment.

The reason I asked was because I do not see the `throw` keyword. In Java, the throw keyword has to be used to throw an instance of an exception. Right? https://www.geeksforgeeks.org/throw-throws-java/

The reason I asked was because I do not see the `throw` keyword. In Java, the throw keyword has to be used to throw an instance of an exception. Right? https://www.geeksforgeeks.org/throw-throws-java/

I will create a separate ticket for this

I will create a separate ticket for this

I had a discussion with Wes Brown about this, he suggested we can add user identification information to be shared with GA, but since we are implementing this on the Core, this feature should be ab...

I had a discussion with Wes Brown about this, he suggested we can add user identification information to be shared with GA, but since we are implementing this on the Core, this feature should be able to be turned on/off and by default should be off...I will create another ticket for this

I am throwing this exception if GA response has 0 rows

I am throwing this exception if GA response has 0 rows

I am using this value to match with visitor report from GA

I am using this value to match with visitor report from GA

This suggests that a deployment of this code requires some files to be loaded in the server. Do you have the corresponding CI/CD code to deploy these files? if not can you create a ticket for doing...

This suggests that a deployment of this code requires some files to be loaded in the server. Do you have the corresponding CI/CD code to deploy these files? if not can you create a ticket for doing exactly that so that it can work in the uat?

You make a very good point Elias. My thought was that information shared with GA is configurable, is this not the case?

You make a very good point Elias. My thought was that information shared with GA is configurable, is this not the case?

The report that you are picking up seems to fully assume the application is sending google analytics data exactly like eLMIS (v2) is sending data to google analytics. For example, eLMIS is sending ...

The report that you are picking up seems to fully assume the application is sending google analytics data exactly like eLMIS (v2) is sending data to google analytics. For example, eLMIS is sending the user id as a custom variable. Is OpenLMIS v3 sending the userID the same way? Will this work?

Why get "all", I assume thousands of openlmis users into userDtos if it is not used?

Why get "all", I assume thousands of openlmis users into userDtos if it is not used?

Does this Exception need to be thrown? Why create it if it does not need to be thrown?

Does this Exception need to be thrown? Why create it if it does not need to be thrown?

I am not sure if I understand your point, but if the question is that on OpenLMIS v3 username is unique then the answer is YES

I am not sure if I understand your point, but if the question is that on OpenLMIS v3 username is unique then the answer is YES

The main pin point of this analytic export was to get users by username, In OpenLMIS v2 username field is not mandatory hence we may get wrong data in Google analytics because GA uses username as v...

The main pin point of this analytic export was to get users by username, In OpenLMIS v2 username field is not mandatory hence we may get wrong data in Google analytics because GA uses username as variable (primary key) to identify a user. We need to verify if openLMIS V3 username field is unique or set user ID
in GA and get these metrics by ID instead of getting by username. Does that make sense?

TZUP-117 Create backend to extract number of users who logged in OpenLMIS
TZUP-117 Create backend to extract number of users who logged in OpenLMIS
TZUP-117: Extract visitor report from Google Analytics

    • -0
    • +96
    ./openlmis/common/web/GoogleAnalyticsControllerIntegrationTest.java
  1. … 15 more files in changeset.
I have renamed this string to FACILITY_CONSUMPTION_REPORT_VIEW as suggested

I have renamed this string to FACILITY_CONSUMPTION_REPORT_VIEW as suggested

This string should be FACILITY_CONSUMPTION_REPORT_VIEW.

This string should be FACILITY_CONSUMPTION_REPORT_VIEW.

hassan I have added permissions management service and its respective DTO and also Implemented permission check for the quantifications APIs

hassan I have added permissions management service and its respective DTO and also Implemented permission check for the quantifications APIs

added permissions management service and its respective DTO Implemented permission check for the quantifications APIs

    • -2
    • +2
    ./openlmis/common/web/QuantificationControllerIntegrationTest.java
  1. … 15 more files in changeset.
Chongsun Ahn I have separated the tests for BadRequest and UnAuthorised. Also, I have changed the name for the extract file to reflect the levels

Chongsun Ahn I have separated the tests for BadRequest and UnAuthorised. Also, I have changed the name for the extract file to reflect the levels