tz-openlmis-commons

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Chongsun Ahn I have separated the tests for BadRequest and UnAuthorised. Also, I have changed the name for the extract file to reflect the levels

Chongsun Ahn I have separated the tests for BadRequest and UnAuthorised. Also, I have changed the name for the extract file to reflect the levels

separated bad request and unauthorised test for the two endpoints

Please separate the two tests into different test cases. That way if it fails, we know which test failed.

Please separate the two tests into different test cases. That way if it fails, we know which test failed.

Please separate the two tests into different test cases. That way if it fails, we know which test failed.

Please separate the two tests into different test cases. That way if it fails, we know which test failed.

Yes, but I'm talking about the actual filename, quantifications.csv. I would prefer something like district_quantifications.csv and facility_quantifications.csv

Yes, but I'm talking about the actual filename, quantifications.csv. I would prefer something like district_quantifications.csv and facility_quantifications.csv

Chongsun Ahn I have edited the QuantificationControllerIntegrationTest and api-definition.yaml to include tests for 400 and 401

Chongsun Ahn I have edited the QuantificationControllerIntegrationTest and api-definition.yaml to include tests for 400 and 401

added tests for BadRequest and UnAuthorized request on quantification endpoints

    • -0
    • +20
    /src/main/resources/api-definition.yaml
I think since the actual function for both endpoints is quantification, then I think having the same controller with two different endpoints differentiating the district and facility purpose is muc...

I think since the actual function for both endpoints is quantification, then I think having the same controller with two different endpoints differentiating the district and facility purpose is much better.

I don't see that some of my initial comments have been resolved.

I don't see that some of my initial comments have been resolved.

Do we want to use the same filename for both extracts? It seems like a more descriptive filename might be better.

Do we want to use the same filename for both extracts? It seems like a more descriptive filename might be better.

Don't you need to check for 400 Bad Request if facility is not provided, since it is required?

Don't you need to check for 400 Bad Request if facility is not provided, since it is required?

Don't you need to check for 400 Bad Request if district is not provided, since it is required?

Don't you need to check for 400 Bad Request if district is not provided, since it is required?

Hi Boniface Chacha i'm able to see if permission rights to view the report has been added? i.e FACILITY_CONSUMPTION_REPORT_VIEW and DISTRICT_CONSUMPTION_REPORT_VIEW

Hi Boniface Chacha
i'm able to see if permission rights to view the report has been added? i.e FACILITY_CONSUMPTION_REPORT_VIEW and DISTRICT_CONSUMPTION_REPORT_VIEW

correcting documentaion for the quantification API specification

    • -30
    • +6
    /src/main/resources/api-definition.yaml
I'm not sure if it's possible, but it would be good to have a test class for this.

I'm not sure if it's possible, but it would be good to have a test class for this.

You should have a test for returning 400 and 403 for this API.

You should have a test for returning 400 and 403 for this API.

You should have a test for returning 400 and 403 for this API.

You should have a test for returning 400 and 403 for this API.

Since you are not asking for a specific resource, you do not need to return a 404 Not Found. Rather, if a csv is not found, I believe it would just return no results.

Since you are not asking for a specific resource, you do not need to return a 404 Not Found. Rather, if a csv is not found, I believe it would just return no results.

Since you are not asking for a specific resource, you do not need to return a 404 Not Found. Rather, if a csv is not found, I believe it would just return no results.

Since you are not asking for a specific resource, you do not need to return a 404 Not Found. Rather, if a csv is not found, I believe it would just return no results.

Please pluralize, make into "facilityLevelQuantifications"

Please pluralize, make into "facilityLevelQuantifications"

Please pluralize, make into "districtLevelQuantifications"

Please pluralize, make into "districtLevelQuantifications"

TZUP-163 Creation of the Health Commodities Quantification Exports
TZUP-163 Creation of the Health Commodities Quantification Exports
TZUP-163 Creation of the Health Commodities Quantification Exports
TZUP-163 Creation of the Health Commodities Quantification Exports
Merge branch 'TZUP-163-CHACHA'

    • -0
    • +90
    /src/main/resources/api-definition.yaml
added code formatting and documentation

  1. … 14 more files in changeset.
Can you give an overview of the changes here? There is a lot of code to review and the objectives don't explain it well.

Can you give an overview of the changes here? There is a lot of code to review and the objectives don't explain it well.