tz-equipment

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Adding enabled filter in Equipment Types , Discipline and Equipment Category API.
Adding enabled filter in Equipment Types , Discipline and Equipment Category API.
TZUP-193 CRUD API to manage Equipment Test types
TZUP-193 CRUD API to manage Equipment Test types
Adding enabled filter in Equipment Types , Discipline and Equipment Category API.

TZUP-193 CRUD API to manage Equipment Test types

    • -0
    • +102
    /src/main/resources/api-definition.yaml
    • -0
    • +40
    /src/main/resources/schemas/equipmentTestType.json
    • -0
    • +25
    /src/main/resources/schemas/equipmentTestTypePage.json
Typo - Renaming EquipmentTyeDataBuilder to EquipmentTypeDataBuilder TZUP-150 Renaming shouldFindActive...
Typo - Renaming EquipmentTyeDataBuilder to EquipmentTypeDataBuilder TZUP-150 Renaming shouldFindActive...
Typo - Renaming EquipmentTyeDataBuilder to EquipmentTypeDataBuilder TZUP-150 Renaming shouldFindActive to shouldFindEnabled

Okey. I will rename this.

Okey. I will rename this.

Please do not resolve my comments. When I review changes, I will resolve them.

Please do not resolve my comments. When I review changes, I will resolve them.

No I mean the class is called EquipmentTyeDataBuilder, but it should be EquipmentTypeDataBuilder. it is missing the p in Type

No I mean the class is called EquipmentTyeDataBuilder, but it should be EquipmentTypeDataBuilder. it is missing the p in Type

Thank you. I will fix that.

Thank you. I will fix that.

This was added to solve testing issues in Equipment category since it depend on them. Those two lines was not tested during development of Equipment Types API.

This was added to solve testing issues in Equipment category since it depend on them. Those two lines was not tested during development of Equipment Types API.

No I mean the name of the test case says shouldFindActive, even though the method is called findByEnabled.

No I mean the name of the test case says shouldFindActive, even though the method is called findByEnabled.

The name was changed from active not enabled at line 128.

The name was changed from active not enabled at line 128.

Name still says active

Name still says active

typo, EquipmentTypeDataBuilder

typo, EquipmentTypeDataBuilder

TZUP-150 - Renaming table equipment_category to equipment_categories - Adding mandatory field in equipmentCategory.json - Adding testing for PUT in equipment category - Changing column active to enabled

TZUP-150 - Renaming table equipment_category to equipment_categories - Adding mandatory field in equipmentCategory.json - Adding testing for PUT in equipment category

Chongsun Ahn I have discussed with hassan on this issue. We concluded that the column active is needed for deactivating and activating equipment category. Also the functional test issue should be o...

Chongsun Ahn I have discussed with hassan on this issue. We concluded that the column active is needed for deactivating and activating equipment category. Also the functional test issue should be on other ticket since it is Many to one relationship with equipment category. Wes Brown

Missing tests for PUT return code 200 and 400.

Missing tests for PUT return code 200 and 400.

Is this necessary? It doesn't seem to be used anywhere, except in tests.

Is this necessary? It doesn't seem to be used anywhere, except in tests.

equipment_category table should be pluralized, i.e. equipment_categories.

equipment_category table should be pluralized, i.e. equipment_categories.

The Jira issue says that displayOrder, equipment type, discipline, functional test are also required, but I don't see that defined here?

The Jira issue says that displayOrder, equipment type, discipline, functional test are also required, but I don't see that defined here?

The Jira issue talks about a "functional test" property, but I don't see that in the code? And there is an "active" property, but I don't see that in the Jira issue?

The Jira issue talks about a "functional test" property, but I don't see that in the code? And there is an "active" property, but I don't see that in the Jira issue?

TZUP-150 Create equipment category API
TZUP-150 Create equipment category API
Fixed build error

TZUP-150 - Fixed bug for Equipment Category API

TZUP-150 - Create A Backend API to manage Equipment Category

    • -0
    • +102
    /src/main/resources/api-definition.yaml
    • -0
    • +40
    /src/main/resources/schemas/equipmentCategory.json
    • -0
    • +25
    /src/main/resources/schemas/equipmentCategoryPage.json