openlmis-stockmanagement-ui / src

stockmanagement

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 12 Oct 2021
9:50 pm

Paweł Muchowski

5:07 pm

Krzysztof Pasiek

Monday 11 Oct 2021
4:28 pm

Paweł Muchowski

User should not see the home page, he should be redirected to the new view. If this is set to the login page user will not be able to open the application offline, because login does not work offline.

User should not see the home page, he should be redirected to the new view.
If this is set to the login page user will not be able to open the application offline, because login does not work offline.

12:43 pm

Krzysztof Pasiek

shouldn't it be the home screen url or login page? Is it related to https://openlmis.atlassian.net/browse/OLMIS-7412 point 1?

shouldn't it be the home screen url or login page?

Is it related to https://openlmis.atlassian.net/browse/OLMIS-7412 point 1?

8:08 am

Paweł Muchowski

OLMIS-7315: Add manifest and service worker configuration for PWA
OLMIS-7315: Add manifest and service worker configuration for PWA
7:30 am

Paweł Muchowski

OLMIS-7315: Fix navigation on mobile

Options
    • -1
    • +1
    ./stockmanagement.routes.js
  2. … 5 more files in changeset.
Wednesday 28 Jul 2021
8:05 am

Krzysztof Pasiek

7:51 am

Paweł Muchowski

Tuesday 27 Jul 2021
7:23 am

Krzysztof Pasiek

done

done

7:16 am

Paweł Muchowski

yes, I think we should

yes, I think we should

7:13 am

Paweł Muchowski

you should remove this if it's not used

you should remove this if it's not used

Thursday 22 Jul 2021
11:11 am

Krzysztof Pasiek

done

done

11:10 am

Krzysztof Pasiek

done

done

6:43 am

Krzysztof Pasiek

Shouldn't we show the 'Home' tab in the menu?

Shouldn't we show the 'Home' tab in the menu?

Wednesday 21 Jul 2021
2:23 pm

Paweł Muchowski

if this is the default value it should be false

if this is the default value it should be false

2:19 pm

Paweł Muchowski

I think you should create a method in the controller and move this logic there, also instead of checking the width you should use the window.matchMedia and check if it's standalone application

I think you should create a method in the controller and move this logic there,
also instead of checking the width you should use the window.matchMedia and check if it's standalone application

2:13 pm

Paweł Muchowski

this should be false by default, so you don't need to add this option if it's false

this should be false by default, so you don't need to add this option if it's false

11:45 am

Krzysztof Pasiek

OLMIS-7318 Added the ability to unnecessary modules on mobile by using...
OLMIS-7318 Added the ability to unnecessary modules on mobile by using...
10:42 am

Krzysztof Pasiek

OLMIS-7318 Added the ability to unnecessary modules on mobile by using showInNavigationInLowResolutions

Options
    • -1
    • +2
    ./stockmanagement.routes.js
  2. … 7 more files in changeset.
Friday 21 Aug 2020
6:23 am

Aleksandra Sołtys

5:50 am

Adrian Świszcz and Klaudia Pałkowska

Wednesday 19 Aug 2020
11:48 am

Paulina Buzderewicz

9:21 am

Aleksandra Sołtys

This function is called by the service, and the service is called by factory in which we search for individual drafts in a loop by a given program and facility. Thanks to this, we do not have to ca...

This function is called by the service, and the service is called by factory in which we search for individual drafts in a loop by a given program and facility. Thanks to this, we do not have to call this physicalInventoryDraftCacheService in factory or routes. Only the physicalInventoryService knows and call physicalInventoryDraftCacheService

8:59 am

Aleksandra Sołtys

if there are no drafts in local storage, an empty list will be returned

if there are no drafts in local storage, an empty list will be returned

8:46 am

Paulina Buzderewicz

Then the name of this function could be "searchDrafts" or just "search".

Then the name of this function could be "searchDrafts" or just "search".

8:44 am

Paulina Buzderewicz

I guess we should search cached drafts for all programs for given facility. In this case searching just by facilityId would be enough if we want to display the list of available drafts.

I guess we should search cached drafts for all programs for given facility. In this case searching just by facilityId would be enough if we want to display the list of available drafts.

8:42 am

Paulina Buzderewicz

I think we should call this search when we open the list of drafts, not the particular draft.

I think we should call this search when we open the list of drafts, not the particular draft.

8:41 am

Klaudia Pałkowska

Could we refactor this file to use 'this.(...)' instead of local vars?

Could we refactor this file to use 'this.(...)' instead of local vars?

8:38 am

Klaudia Pałkowska

Please add 'this.' to avoid memory leaks.

Please add 'this.' to avoid memory leaks.

8:36 am

Klaudia Pałkowska

Could we use PhysicalInventoryLineItemDataBuilder here?

Could we use PhysicalInventoryLineItemDataBuilder here?