openlmis-stockmanagement-ui / src

stock-unpack-kit-creation

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 Sep 2021
9:05 pm

Paweł Muchowski

8:02 am

Krzysztof Pasiek

Saturday 25 Sep 2021
10:00 pm

Paweł Muchowski

OLMIS-7397: Revert changes made in tests
OLMIS-7397: Revert changes made in tests
Friday 24 Sep 2021
6:53 am

Paweł Muchowski

OLMIS-7397: Revert changes made in tests

This reverts commit cb5aef05f80737da454315a7a5ecde342e0ef1a9.

Options
    • -9
    • +9
    ./unpack-kit-creation.routes.spec.js
  2. … 41 more files in changeset.
Wednesday 15 Sep 2021
6:49 am

Paweł Muchowski

Wednesday 08 Sep 2021
6:08 am

Krzysztof Pasiek

Tuesday 07 Sep 2021
3:02 pm

Paweł Muchowski

OLMIS-7314: Fix tests after karma upgrade
OLMIS-7314: Fix tests after karma upgrade
12:02 pm

Paweł Muchowski

OLMIS-7314: Fix tests after karma upgrade

Options
    • -9
    • +9
    ./unpack-kit-creation.routes.spec.js
  2. … 40 more files in changeset.
Tuesday 27 Apr 2021
8:48 am

Paweł Muchowski

8:45 am

Aleksandra Sołtys

OLMIS-6813: Displaying products with SoH equal 0 on the Adjustments screen
OLMIS-6813: Displaying products with SoH equal 0 on the Adjustments screen
8:40 am

Aleksandra Sołtys

7:18 am

saleksandra <soltys.ola@gmail.com>

OLMIS-6813: Displaying products with SoH equal 0 on the Adjustments screen

Options
    • -1
    • +1
    ./unpack-kit-creation.routes.js
    • -1
    • +1
    ./unpack-kit-creation.routes.spec.js
  3. … 4 more files in changeset.
Monday 15 Apr 2019
10:29 am

Adugna Worku

10:05 am

Nikodem Graczewski and Mateusz Kwiatkowski

9:03 am

Adugna Worku

I would prefer the original way

I would prefer the original way

8:54 am

Nikodem Graczewski

I see. I would stick with the original approach then so we don't introduce any compatibility issues. However, we could use _.flatten instead. I'll leave it up to you.

I see. I would stick with the original approach then so we don't introduce any compatibility issues. However, we could use _.flatten instead. I'll leave it up to you.

8:40 am

Adugna Worku

Nikodem Graczewski There is something tricky here. Array.prototype.flatMap() works on chrome version >=69 Unfortunately my virtual machine Chrome version is 66. And flatMap is not supported. That...

Nikodem Graczewski There is something tricky here.

Array.prototype.flatMap() works on chrome version >=69

Unfortunately my virtual machine Chrome version is 66. And flatMap is not supported. That was the reason i was saying its not working.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap

So changing to flatMap won't that create a problem?

8:31 am

Adugna Worku

// Real lineItem JSON objectvar lineItems =[{"$errors":{"quantityInvalid":false,"occurredDateInvalid":false},"$previewSOH":99,"stockCard":{"id":"e4cd8e1a-8f3c-48d4-891c-fa5160832005","href":"https:...
// Real lineItem JSON object
var lineItems =[{"$errors":{"quantityInvalid":false,"occurredDateInvalid":false},"$previewSOH":99,"stockCard":{"id":"e4cd8e1a-8f3c-48d4-891c-fa5160832005","href":"https://uat.openlmis.org/api/stockCards/e4cd8e1a-8f3c-48d4-891c-fa5160832005"},"orderable":{"productCode":"C118","dispensable":{"dispensingUnit":"10 tab strip","displayUnit":"10 tab strip"},"fullProductName":"Stomachica","description":"Product description goes here.","netContent":1,"packRoundingThreshold":0,"roundToZero":false,"programs":[{"programId":"dce17f2e-af3e-40ad-8e00-3496adef44c3","orderableDisplayCategoryId":"15b8ef1f-a5d6-42dd-95bf-bb68a4504e82","orderableCategoryDisplayName":"Oral contraceptive","orderableCategoryDisplayOrder":6,"active":true,"fullSupply":true,"displayOrder":3,"dosesPerPatient":1,"pricePerPack":5.1}],"children":[{"orderable":{"id":"25665e10-cca7-44c0-b508-e95600d8fb99"},"quantity":10},{"orderable":{"id":"d4dbd20e-8ce2-480e-a019-4a90d115719c"},"quantity":20}],"identifiers":{},"extraData":{},"meta":{"lastUpdated":"2019-04-15T00:55:18.564Z[GMT]","versionId":"2"},"id":"0dc9c1ad-2266-4fb3-ad74-993c38b8c28a"},"lot":null,"stockOnHand":99,"processedDate":"2019-04-15T00:57:46.158Z","occurredDate":"2019-04-15","displayLotMessage":"Product has no lots","reason":{"name":"Unpack Kit","description":null,"reasonType":"DEBIT","reasonCategory":"AGGREGATION","isFreeTextAllowed":false,"tags":["consumed"],"id":"9b4b653a-f319-4a1b-bb80-8d6b4dd6cc12","creditReasonType":false,"debitReasonType":true,"adjustmentReasonCategory":false},"reasonFreeText":null,"quantity":2}];

lineItems.flatMap(function(lineItem) {
    return lineItem.orderable.children.map(function(constituent) {
        return _.extend({}, constituent, {
            reason: creditReason,
            occurredDate: lineItem.occurredDate,
            quantity: lineItem.quantity * constituent.quantity
        });
    })
});
8:26 am

Adugna Worku

OLMIS-6113 : Create UI for kit unpacking in stock management
OLMIS-6113 : Create UI for kit unpacking in stock management
7:19 am

Nikodem Graczewski

I've checked and for AdjustmnetCreationController tests, exactly the same objects are created (and the tests pass). Could you provide a case for which this fails?

I've checked and for AdjustmnetCreationController tests, exactly the same objects are created (and the tests pass). Could you provide a case for which this fails?

1:08 am

Adugna Worku

This doesn't return object in a desired format. I will stick with the existing implementation

This doesn't return object in a desired format. I will stick with the existing implementation

12:59 am

Adugna Worku

Kits unpacking increased test coverage and solve sonar issue

Options
    • -1
    • +2
    ./unpack-kit-creation.module.js
    • -28
    • +23
    ./unpack-kit-creation.routes.js
    • -66
    • +60
    ./unpack-kit-creation.routes.spec.js
  4. … 4 more files in changeset.
Friday 12 Apr 2019
1:06 pm

Adugna Worku

OLMIS-6113: Added a review comments

Options
    • -5
    • +2
    ./messages_en.json
    • -3
    • +3
    ./unpack-kit-creation.routes.js
  3. … 5 more files in changeset.
11:30 am

Nikodem Graczewski

Ugh, this is a really strange design.

Ugh, this is a really strange design.

10:22 am

Adugna Worku

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

10:22 am

Adugna Worku

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

10:20 am

Adugna Worku

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

10:12 am

Adugna Worku

ditto

ditto

10:11 am

Adugna Worku

Issue, receive and unpack pages uses a single html view but separate message files. The prefix of the message key is up-to the page that will be rendered but the suffix is already hard coded in the...

Issue, receive and unpack pages uses a single html view but separate message files. The prefix of the message key is up-to the page that will be rendered but the suffix is already hard coded in the html file.

So in this case the message value is appropriate but the key is not. changing the key required all the message to be changed in the other modules also. So this implementation shall be refactored for the future but till then the html file is our guide.

Take a look at stock-adjustment/stock-adjustment.html

8:50 am

Adugna Worku

Sure

Sure