openlmis-stockmanagement-ui / src / stock-physical-inventory

messages_en.json

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 20 Sep 17
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 20 Sep 2017
2:30 pm

Paweł Albecki

2:13 pm

Nikodem Graczewski

2:12 pm

Paweł Albecki

fxed

fxed

2:10 pm

Nikodem Graczewski

Shouldn't this be in else block?

Shouldn't this be in else block?

1:36 pm

Paweł Albecki

1:06 pm

Paweł Albecki

OLMIS-3183: move service and factory to new module
OLMIS-3183: move service and factory to new module
1:00 pm

Paweł Albecki

OLMIS-3183: move service and factory to new module

Options
    • -0
    • +13
    ./messages_en.json
  2. … 22 more files in changeset.
12:14 pm

Paweł Albecki

OLMIS-3183: Rename module stock-physical-inventory

Options
    • -13
    • +0
    ./messages_en.json
  2. … 19 more files in changeset.
Wednesday 03 May 2017
1:50 pm

Nick Reid

Thursday 27 Apr 2017
7:09 am

Yi Deng <dydyistc@gmail.com>

[code review] if user has no home facility return empty drafts

Options
    • -1
    • +1
    ./messages_en.json
  2. … 2 more files in changeset.
Monday 17 Apr 2017
6:24 am

Yi Deng <dydyistc@gmail.com>

OLMIS-2349 create message file for physical inventory

Options
    • -0
    • +13
    ./messages_en.json
  2. … 2 more files in changeset.
Monday 10 Apr 2017
7:43 am

Hongwei Peng

6:09 am

Hongwei Peng

Since this state is the root state of stockmangement, we do need an `ui-view` markup at here.

Since this state is the root state of stockmangement, we do need an `ui-view` markup at here.

Friday 07 Apr 2017
9:17 am

Hongwei Peng

We create a tech debt issue for this. Will be implemented in ui-components soon.

We create a tech debt issue for this. Will be implemented in ui-components soon.

Tuesday 04 Apr 2017
7:14 pm

Nick Reid

7:12 pm

Nick Reid

This should be changed over to the OpenLMIS-UI Modal Service

This should be changed over to the OpenLMIS-UI Modal Service

6:24 pm

Nick Reid

this file should be named `reason-form-modal.factory.js` or `reason-form.modal.js`

this file should be named `reason-form-modal.factory.js` or `reason-form.modal.js`

6:18 pm

Nick Reid

Please don't make the table fullwidth....

Please don't make the table fullwidth....

6:14 pm

Nick Reid

This is the default pagination size? If so, please pull that constant... otherwise, please make this a configurable constant using the `@@` syntax

This is the default pagination size? If so, please pull that constant... otherwise, please make this a configurable constant using the `@@` syntax

6:12 pm

Nick Reid

This seems to be old code.... I can't find where $stateParams.program would be directly set IMHO, you might want to wrap this program definition and open an alert modal if the programId doesn't ex...

This seems to be old code.... I can't find where $stateParams.program would be directly set

IMHO, you might want to wrap this program definition and open an alert modal if the programId doesn't exist...

4:55 pm

Nick Reid

Note: We don't make tables full width, they are as big as they need to be (fluid width) – this is a detail that was impossible to communicate through the design process (which we should work on)

Note: We don't make tables full width, they are as big as they need to be (fluid width) – this is a detail that was impossible to communicate through the design process (which we should work on)

4:44 pm

Nick Reid

PS: You don't need to add the form-control class (its implicitly applied with CSS)

PS: You don't need to add the form-control class (its implicitly applied with CSS)

Monday 03 Apr 2017
11:01 pm

Nick Reid

Ideally this would have been a reusable angular component, which would look something like this: <openlmis-progress-bar percentage="vm.getPercentage()" message="Some message" />

Ideally this would have been a reusable angular component, which would look something like this: 

  <openlmis-progress-bar percentage="vm.getPercentage()" message="Some message" />
10:57 pm

Nick Reid

Just FYI - you don't need the outside button-group div, this would look the same     <button class="primary" ng-click="">{{'button.submit' | message}}</button>

Just FYI - you don't need the outside button-group div, this would look the same

 
  <button class="primary" ng-click="">{{'button.submit' | message}}</button>
10:23 pm

Nick Reid

You should use an interpolated sting for this – it is implemented in our message filter implementation see: http://build.openlmis.org/job/OpenLMIS-reference-ui/lastSuccessfulBuild/artifact/build/do...

You should use an interpolated sting for this – it is implemented in our message filter implementation see:
http://build.openlmis.org/job/OpenLMIS-reference-ui/lastSuccessfulBuild/artifact/build/docs/index.html#/api/openlmis-i18n.filter:message

These unit tests are helpful to look at:
https://github.com/OpenLMIS/openlmis-ui-components/blob/master/src/openlmis-i18n/message.service.spec.js#L29-L30

The reason is that some languages might change the grammar entirely, so we should pass the dynamic value into the message string (ie vm.facility.name)

10:09 pm

Nick Reid

This is a general note — I've been meaning to drop support for underscore.js within our UI, since we don't use it — except stock management code

This is a general note — I've been meaning to drop support for underscore.js within our UI, since we don't use it — except stock management code

9:52 pm

Nick Reid

This message files should be separated into the specific module/directories that they are actually being used. The idea is to make string specific to a module and not reuse strings See OLMIS-1609 ...

This message files should be separated into the specific module/directories that they are actually being used. The idea is to make string specific to a module and not reuse strings

See OLMIS-1609 for the new instructions about how to name strings

9:47 pm

Nick Reid

Instead of adding namless divs into the markup, its preferable to reference the UI-Router parent view ~ which the children of abstract states should actually do... https://github.com/angular-ui/ui...

Instead of adding namless divs into the markup, its preferable to reference the UI-Router parent view ~ which the children of abstract states should actually do...

https://github.com/angular-ui/ui-router/wiki/Multiple-Named-Views#view-names---relative-vs-absolute-names

There is work being done to improve this in OLMIS-2107 (which adds breadcrumbs)

9:44 pm

Nick Reid

This is showing up at a higher priority than the administration screen. I suggest you set this to the default value of 10 (which other menu items except for home should also follow) There is a bug...

This is showing up at a higher priority than the administration screen. I suggest you set this to the default value of 10 (which other menu items except for home should also follow)

There is a bug for this OLMIS-2204

9:42 pm

Nick Reid

test trigger
test trigger