openlmis-stockmanagement-ui / src / stock-physical-inventory-draft

physical-inventory-draft-toolbar.html

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 04 Sep 20
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 04 Sep 2020
10:42 am

Adrian Świszcz

10:32 am

Klaudia Pałkowska and Paulina Buzderewicz

8:28 am

Adrian Świszcz

OLMIS-6900: Added message to save button about offline action

Options
    • -1
    • +1
    ./physical-inventory-draft-toolbar.html
7:01 am

Adrian Świszcz

Our tester said that these buttons should return the message "This action can't be completed while offline."

Our tester said that these buttons should return the message "This action can't be completed while offline."

6:58 am

Paulina Buzderewicz

Hm, should it work this way? Because on requisition screen they are also disabled when offline.

Hm, should it work this way? Because on requisition screen they are also disabled when offline.

6:49 am

Adrian Świszcz

Thats because when they are turned off, they do not return messages that the operation cannot be performed offline

Thats because when they are turned off, they do not return messages that the operation cannot be performed offline

6:47 am

Paulina Buzderewicz

Why we don't want to have these buttons disabled while offline?

Why we don't want to have these buttons disabled while offline?

5:34 am

Adrian Świszcz

OLMIS-6900: Added message to buttons about offline action
OLMIS-6900: Added message to buttons about offline action
Thursday 03 Sep 2020
12:54 pm

Adrian Świszcz

OLMIS-6900: Added message to buttons about offline action

Options
    • -2
    • +2
    ./physical-inventory-draft-toolbar.html
Wednesday 02 Sep 2020
7:09 am

Adrian Świszcz

6:36 am

Klaudia Pałkowska and Paulina Buzderewicz

Tuesday 01 Sep 2020
2:32 pm

Sebastian Brudziński

typo?

typo?

7:34 am

Paulina Buzderewicz

Could we make this check more descriptive by extracting it to another boolean function?

Could we make this check more descriptive by extracting it to another boolean function?

Monday 31 Aug 2020
5:44 pm

Adrian Świszcz

OLMIS-6900: Fix for butons in offline mode and draft fetch from local storage

Options
    • -3
    • +3
    ./physical-inventory-draft-toolbar.html
  2. … 3 more files in changeset.
12:27 pm

Paulina Buzderewicz

For now there is a chance, that we will have two drafts with the same program and facility cached in our local storage, so the draft id can be needed here. But in this case we don't need searching ...

For now there is a chance, that we will have two drafts with the same program and facility cached in our local storage, so the draft id can be needed here. But in this case we don't need searching by program and facility, I guess.

12:22 pm

Adrian Świszcz

The point is that when we have for example 2 drafts for the same facility and program in the list, when opening a draft we don't want to load random data, but we want to load data for the draft ind...

The point is that when we have for example 2 drafts for the same facility and program in the list, when opening a draft we don't want to load random data, but we want to load data for the draft indicated under a given id

12:19 pm

Klaudia Pałkowska

Please update the changelog.

Please update the changelog.

12:18 pm

Klaudia Pałkowska

It shouldn't be possible to have two drafts for the same program and facility.

It shouldn't be possible to have two drafts for the same program and facility.

12:16 pm

Adrian Świszcz

Because when there are for example 2 drafts for the same program and facility and there is no id included, it can happen that incorrect data for another draft is loaded.

Because when there are for example 2 drafts for the same program and facility and there is no id included, it can happen that incorrect data for another draft is loaded.

12:15 pm

Klaudia Pałkowska

Moving this was necessary?

Moving this was necessary?

12:14 pm

Klaudia Pałkowska

Why we need draft id now?

Why we need draft id now?

7:28 am

Klaudia Pałkowska

This always returns me an empty list so I don't have reasons to select while offline.

This always returns me an empty list so I don't have reasons to select while offline.

Wednesday 26 Aug 2020
11:43 am

Klaudia Pałkowska

I believe it was recently added... Why we don't need it anymore?

I believe it was recently added... Why we don't need it anymore?

11:35 am

Klaudia Pałkowska

Do we need a separate label for the offline draft?

Do we need a separate label for the offline draft?

11:34 am

Paulina Buzderewicz

This should be refactored to avoid code duplication.

This should be refactored to avoid code duplication.

11:25 am

Adrian Świszcz

OLMIS-6900 - Add possibility to open locally saved draft while offline
OLMIS-6900 - Add possibility to open locally saved draft while offline
7:27 am

Adrian Świszcz

OLMIS-6900: Add ability to open locally saved drafts offline

Options
    • -3
    • +3
    ./physical-inventory-draft-toolbar.html
  2. … 9 more files in changeset.
Wednesday 20 Sep 2017
2:37 pm

Mateusz Kwiatkowski and Nikodem Graczewski

2:33 pm

Paweł Albecki

2:30 pm

Paweł Albecki

https://review.openlmis.org/cru/#FEOLMIS-1923CFR-29468

https://review.openlmis.org/cru/#FEOLMIS-1923CFR-29468