openlmis-stockmanagement-ui / src

stock-constants

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Apr 2019
10:29 am

Adugna Worku

10:05 am

Nikodem Graczewski and Mateusz Kwiatkowski

9:03 am

Adugna Worku

I would prefer the original way

I would prefer the original way

8:54 am

Nikodem Graczewski

I see. I would stick with the original approach then so we don't introduce any compatibility issues. However, we could use _.flatten instead. I'll leave it up to you.

I see. I would stick with the original approach then so we don't introduce any compatibility issues. However, we could use _.flatten instead. I'll leave it up to you.

8:40 am

Adugna Worku

Nikodem Graczewski There is something tricky here. Array.prototype.flatMap() works on chrome version >=69 Unfortunately my virtual machine Chrome version is 66. And flatMap is not supported. That...

Nikodem Graczewski There is something tricky here.

Array.prototype.flatMap() works on chrome version >=69

Unfortunately my virtual machine Chrome version is 66. And flatMap is not supported. That was the reason i was saying its not working.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap

So changing to flatMap won't that create a problem?

8:31 am

Adugna Worku

// Real lineItem JSON objectvar lineItems =[{"$errors":{"quantityInvalid":false,"occurredDateInvalid":false},"$previewSOH":99,"stockCard":{"id":"e4cd8e1a-8f3c-48d4-891c-fa5160832005","href":"https:...
// Real lineItem JSON object
var lineItems =[{"$errors":{"quantityInvalid":false,"occurredDateInvalid":false},"$previewSOH":99,"stockCard":{"id":"e4cd8e1a-8f3c-48d4-891c-fa5160832005","href":"https://uat.openlmis.org/api/stockCards/e4cd8e1a-8f3c-48d4-891c-fa5160832005"},"orderable":{"productCode":"C118","dispensable":{"dispensingUnit":"10 tab strip","displayUnit":"10 tab strip"},"fullProductName":"Stomachica","description":"Product description goes here.","netContent":1,"packRoundingThreshold":0,"roundToZero":false,"programs":[{"programId":"dce17f2e-af3e-40ad-8e00-3496adef44c3","orderableDisplayCategoryId":"15b8ef1f-a5d6-42dd-95bf-bb68a4504e82","orderableCategoryDisplayName":"Oral contraceptive","orderableCategoryDisplayOrder":6,"active":true,"fullSupply":true,"displayOrder":3,"dosesPerPatient":1,"pricePerPack":5.1}],"children":[{"orderable":{"id":"25665e10-cca7-44c0-b508-e95600d8fb99"},"quantity":10},{"orderable":{"id":"d4dbd20e-8ce2-480e-a019-4a90d115719c"},"quantity":20}],"identifiers":{},"extraData":{},"meta":{"lastUpdated":"2019-04-15T00:55:18.564Z[GMT]","versionId":"2"},"id":"0dc9c1ad-2266-4fb3-ad74-993c38b8c28a"},"lot":null,"stockOnHand":99,"processedDate":"2019-04-15T00:57:46.158Z","occurredDate":"2019-04-15","displayLotMessage":"Product has no lots","reason":{"name":"Unpack Kit","description":null,"reasonType":"DEBIT","reasonCategory":"AGGREGATION","isFreeTextAllowed":false,"tags":["consumed"],"id":"9b4b653a-f319-4a1b-bb80-8d6b4dd6cc12","creditReasonType":false,"debitReasonType":true,"adjustmentReasonCategory":false},"reasonFreeText":null,"quantity":2}];

lineItems.flatMap(function(lineItem) {
    return lineItem.orderable.children.map(function(constituent) {
        return _.extend({}, constituent, {
            reason: creditReason,
            occurredDate: lineItem.occurredDate,
            quantity: lineItem.quantity * constituent.quantity
        });
    })
});
8:26 am

Adugna Worku

OLMIS-6113 : Create UI for kit unpacking in stock management
OLMIS-6113 : Create UI for kit unpacking in stock management
7:19 am

Nikodem Graczewski

I've checked and for AdjustmnetCreationController tests, exactly the same objects are created (and the tests pass). Could you provide a case for which this fails?

I've checked and for AdjustmnetCreationController tests, exactly the same objects are created (and the tests pass). Could you provide a case for which this fails?

1:08 am

Adugna Worku

This doesn't return object in a desired format. I will stick with the existing implementation

This doesn't return object in a desired format. I will stick with the existing implementation

Friday 12 Apr 2019
1:06 pm

Adugna Worku

OLMIS-6113: Added a review comments

Options
    • -2
    • +5
    ./reason-categories.constant.js
    • -1
    • +7
    ./reason-categories.constant.spec.js
  3. … 5 more files in changeset.
11:30 am

Nikodem Graczewski

Ugh, this is a really strange design.

Ugh, this is a really strange design.

10:22 am

Adugna Worku

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

10:22 am

Adugna Worku

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

10:20 am

Adugna Worku

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

10:12 am

Adugna Worku

ditto

ditto

10:11 am

Adugna Worku

Issue, receive and unpack pages uses a single html view but separate message files. The prefix of the message key is up-to the page that will be rendered but the suffix is already hard coded in the...

Issue, receive and unpack pages uses a single html view but separate message files. The prefix of the message key is up-to the page that will be rendered but the suffix is already hard coded in the html file.

So in this case the message value is appropriate but the key is not. changing the key required all the message to be changed in the other modules also. So this implementation shall be refactored for the future but till then the html file is our guide.

Take a look at stock-adjustment/stock-adjustment.html

8:50 am

Adugna Worku

Sure

Sure

8:46 am

Nikodem Graczewski

I see. The logic for this is in multiple places, which made it hard to follow for me. We could most likely refactor this a bit.

I see. The logic for this is in multiple places, which made it hard to follow for me. We could most likely refactor this a bit.

7:03 am

Adugna Worku

This piece of code will return a random reason No. when the unpack reason view loaded, take a look at unpack-kit-creation.routes.js line 78. Method returns ONLY two reasons of type AGGREGATION. T...

This piece of code will return a random reason


No. when the unpack reason view loaded, take a look at unpack-kit-creation.routes.js line 78. Method returns ONLY two reasons of type AGGREGATION. They are -
1. Kit Unpack (DEBIT)
2. Unpacked From Kit (CREDIT).

So we will use Unpacked From Kit (CREDIT) reason for the constituent line item

Thursday 11 Apr 2019
9:50 pm

Nikodem Graczewski

I understand, but will that button show on any other screen than Unpack? If not, then I think we can omit the check for the state. If we don't want to do that we should rework it into fail-fast app...

I understand, but will that button show on any other screen than Unpack? If not, then I think we can omit the check for the state. If we don't want to do that we should rework it into fail-fast approach so instead of doing:

if (adjustmnetType.state === 'kitunpack') {
   //rest of the code
}


We can do: 

if (adjustmnetType.state !== 'kitunpack') {
    return;
}

//rest of the code
9:11 pm

Nikodem Graczewski

That's because you didn't add the module providing the parent states as a dependency of the unpack-kit-creation module, which is an issue on itself. This result in the parent state not being availa...

That's because you didn't add the module providing the parent states as a dependency of the unpack-kit-creation module, which is an issue on itself. This result in the parent state not being available during the child state registration and thus making the child state unavailable.

9:06 pm

Nikodem Graczewski

This piece of code will return a random reason with CREDIT type (e.x. Facility Return reason). I think unpacking should use one, specific reason, most likely a new one.

This piece of code will return a random reason with CREDIT type (e.x. Facility Return reason). I think unpacking should use one, specific reason, most likely a new one.

9:05 pm

Nikodem Graczewski

This should give the same result: var constituentLineItems = addedLineItems.flatMap(function(lineItem) { return lineItem.orderable.children.map(function(constituent) { return _.extend({...

This should give the same result:

var constituentLineItems = addedLineItems.flatMap(function(lineItem) {
    return lineItem.orderable.children.map(function(constituent) {
        return _.extend({}, constituent, {
            reason: creditReason,
            occurredDate: lineItem.occurredDate,
            quantity: lineItem.quantity * constituent.quantity
        });
    })
});


The use of _.extend prevents us from modifying the original child.

8:53 pm

Nikodem Graczewski

Good catch!

Good catch!

7:41 pm

Adugna Worku

Testing a nested child state with the $location.url(url) is not working and doesn't return the proper state object. Example:- lets say openlmis.stockmanagement.kitunpack is a parent state and open...

Testing a nested child state with the $location.url(url) is not working and doesn't return the proper state object.

Example:-
lets say openlmis.stockmanagement.kitunpack is a parent state and openlmis.stockmanagement.kitunpack.creation is a child state. Using $location.url(url) to change the view with the route URL for the parent state works well. $state object will be returned filled with proper values.

But following the same way for the child state, it yields an empty $state. I have researched before and also used $state.go(''state name') which doesn't work
and $state.current object will be empty. I could't find a reference spec in our repos. I will try to figure out how to test child state but please advice if there is any reference in our repos.

6:33 pm

Adugna Worku

I didn't understood well what you mean by "Facility Return" but we need the CREDIT type reason here. During unpacking, the Kit will be DEBITED from SOH and Kit constituents SOH amount will be CREDI...

I didn't understood well what you mean by "Facility Return" but we need the CREDIT type reason here. During unpacking, the Kit will be DEBITED from SOH and Kit constituents SOH amount will be CREDITED. Kit line item comes from the UI and constituent line item will be generated here with reason type CREDIT.

6:32 pm

Adugna Worku

I am not sure how we can use it here. But her we want to generate new Array objects by accessing a second level depth array of other object with our reducing anything. You can advise me on this.

I am not sure how we can use it here.

But her we want to generate new Array objects by accessing a second level depth array of other object with our reducing anything.

You can advise me on this.

6:12 pm

Adugna Worku

adjustment-creation.controller is shared by - Issue, Receive and Unpack pages. the current method will be executed when the operation is kit unpacking. N.B During unpacking, the user just add the ...

adjustment-creation.controller is shared by - Issue, Receive and Unpack pages. the current method will be executed when the operation is kit unpacking.

N.B During unpacking, the user just add the kit as a line item on the view (table) and since we know the corresponding constituents we generate them behind the scene among with a proper unpacked quantity for each constituent when we finally submit the data.

6:02 pm

Adugna Worku

vm.addedLineItem is an object Which is bound with the table in the view. If the data transformation, generating kit constituents, is done on this object unnecessary and confusing change will be dis...

vm.addedLineItem is an object Which is bound with the table in the view. If the data transformation, generating kit constituents, is done on this object unnecessary and confusing change will be displayed in the view.

Wednesday 10 Apr 2019
4:47 pm

Nikodem Graczewski

This is not the correct way of testing a state. Please use the same approach as in stock-kit-unpack.routes.spec.js.

This is not the correct way of testing a state. Please use the same approach as in stock-kit-unpack.routes.spec.js.