stock-card-summary

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added LotResource to fix splitting long requests
Added LotResource to fix splitting long requests
Refactored usages of LotRepositoryImpl to use LotResource because the second one implements splitting long requests

    • -5
    • +5
    ./stock-card-summary-repository-impl.js
    • -7
    • +7
    ./stock-card-summary-repository-impl.spec.js
  1. … 3 more files in changeset.
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

    • -3
    • +6
    ./can-fulfill-for-me-entry-data-builder.spec.js
    • -4
    • +9
    ./stock-card-summary-data-builder.spec.js
    • -17
    • +19
    ./stock-card-summary-repository-impl.spec.js
    • -8
    • +9
    ./stock-card-summary-repository.spec.js
  1. … 37 more files in changeset.
Enabled eslint

    • -4
    • +6
    ./stock-card-summary-repository-impl.js
  1. … 18 more files in changeset.
Auto-fixed eslint issues

    • -22
    • +23
    ./stock-card-summary-repository-impl.js
  1. … 76 more files in changeset.
OLMIS-4757: Replaced OrderableRepositoryImpl usage with OrderableResource
OLMIS-4757: Replaced OrderableRepositoryImpl usage with OrderableResource
OLMIS-4757: Replaced OrderableRepositoryImpl usage with OrderableResource

    • -5
    • +5
    ./stock-card-summary-repository-impl.js
    • -7
    • +7
    ./stock-card-summary-repository-impl.spec.js
  1. … 3 more files in changeset.
OLMIS-4578: added missing tests

    • -1
    • +1
    ./stock-card-summary-data-builder.spec.js
  1. … 2 more files in changeset.
OLMIS-4578: Added unit test for StockCardSummaryResource

    • -0
    • +39
    ./stock-card-summary-resource.spec.js
I'm on this!

I'm on this!

maybe tests need some update? probably we can mock this resource

maybe tests need some update? probably we can mock this resource

add tests

add tests

OLMIS-4578: removed old code, added resource for stock card summaries
OLMIS-4578: removed old code, added resource for stock card summaries
OLMIS-4578: added stock card summary resource

    • -26
    • +24
    ./stock-card-summary-repository-impl.js
    • -0
    • +36
    ./stock-card-summary-resource.js
OLMIS-4195: Extended CanFulfillForMeEntry and StockCard data builders

    • -1
    • +7
    ./can-fulfill-for-me-entry-data-builder.spec.js
  1. … 1 more file in changeset.
OLMIS-4195: Extended StockCardSummaryDataBuilder

    • -1
    • +12
    ./stock-card-summary-data-builder.spec.js
OLMIS-4195: Fixed a bug with summary orderables not being donwloaded

    • -18
    • +19
    ./stock-card-summary-repository-impl.js
OLMIS-4195: Extended CanFulfillForMeEntry and StockCardSummary data builders

    • -2
    • +8
    ./can-fulfill-for-me-entry-data-builder.spec.js
    • -1
    • +7
    ./stock-card-summary-data-builder.spec.js
But is it important for method caller to know what this method is doing? I think it's better if method details are encapsulated and name is easy to read. I will refactor this code anyway so we can ...

But is it important for method caller to know what this method is doing? I think it's better if method details are encapsulated and name is easy to read. I will refactor this code anyway so we can contunue this discussion later in next review