openlmis-stockmanagement-ui / src

stock-card-summaries

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Apr 2018
11:08 am

Mateusz Kwiatkowski

10:33 am

Nikodem Graczewski , Paweł Albecki and Klaudia Pałkowska

10:15 am

Nikodem Graczewski

I'm on this!

I'm on this!

8:30 am

Mateusz Kwiatkowski

maybe tests need some update? probably we can mock this resource

maybe tests need some update? probably we can mock this resource

8:26 am

Mateusz Kwiatkowski

add tests

add tests

8:25 am

Mateusz Kwiatkowski

OLMIS-4578: removed old code, added resource for stock card summaries
OLMIS-4578: removed old code, added resource for stock card summaries
6:31 am

Mateusz Kwiatkowski

OLMIS-4578: remove old summaries code

Options
    • -72
    • +0
    ./card-sumary-data-builder.spec.js
    • -37
    • +0
    ./card-summaries.module.js
    • -131
    • +0
    ./card-summaries.service.js
    • -151
    • +0
    ./card-summaries.service.spec.js
    • -58
    • +0
    ./card-summary.js
Wednesday 28 Mar 2018
8:34 am

Klaudia Pałkowska

8:34 am

Nikodem Graczewski

8:18 am

Klaudia Pałkowska

Yea, me too https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

Yea, me too

8:11 am

Paweł Albecki

haha, I like that

haha, I like that

7:43 am

Klaudia Pałkowska

Fixed Sonar bugs
Fixed Sonar bugs
7:32 am

Klaudia Pałkowska

Fixed Sonar bugs

Options
    • -2
    • +2
    ./card-summaries.service.js
  2. … 19 more files in changeset.
Tuesday 13 Mar 2018
4:08 pm

Jakub Kondrat

3:48 pm

Mateusz Kwiatkowski and Łukasz Lewczyński

12:21 pm

Jakub Kondrat

done

done

11:59 am

Jakub Kondrat

Yes, the message is shown on the UI. For example, try receiving some vaccine, vaccines did not have dispensing unit. A display unit is shown instead.

Yes, the message is shown on the UI. For example, try receiving some vaccine, vaccines did not have dispensing unit. A display unit is shown instead.

8:40 am

Łukasz Lewczyński

I don't see changes in html/js. This message will be shown properly?

I don't see changes in html/js. This message will be shown properly?

8:40 am

Łukasz Lewczyński

same here

same here

8:39 am

Łukasz Lewczyński

same here

same here

Monday 12 Mar 2018
5:11 pm

Mateusz Kwiatkowski

LGTM, just add changelogs

LGTM, just add changelogs

3:58 pm

Jakub Kondrat

3:58 pm

Jakub Kondrat

OLMIS-4118: Show display unit for Dispensable
OLMIS-4118: Show display unit for Dispensable
3:45 pm

Jakub Kondrat

OLMIS-4118: Show display unit for Dispensable

Options
    • -3
    • +3
    ./card-summaries.service.spec.js
  2. … 8 more files in changeset.
1:01 pm

Paweł Albecki

11:44 am

Mateusz Kwiatkowski and Nikodem Graczewski

Friday 09 Mar 2018
3:09 pm

Paweł Albecki

Thanks for feedback, I hope it look better now

Thanks for feedback, I hope it look better now

12:45 pm

Nikodem Graczewski

This really is an utility factory... Can't we refactor it to be meaningful?

This really is an utility factory... Can't we refactor it to be meaningful?

10:45 am

Nikodem Graczewski

I would say use factory in this case.

I would say use factory in this case.

10:26 am

Paweł Albecki

resolving this as smilar comments are in files

resolving this as smilar comments are in files