Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-7458: Changed message

OLMIS-7458: Add new lots in receive and physical inventory screens
OLMIS-7458: Add new lots in receive and physical inventory screens
OLMIS-7458: Add new lots in receive and physical inventory screens

  1. … 31 more files in changeset.
OLMIS-2557 fix typo

OLMIS-2513 move determine no lot defined message method to orderable-lot-util

  1. … 8 more files in changeset.
[Code review] because added items can be product or product+lot, change text to "items"

OLMIS-2362 add support for lots in add products modal

  1. … 5 more files in changeset.
OLMIS-2349 update message

  1. … 1 more file in changeset.
OLMIS-2349 create message file for stock confirm discard

  1. … 2 more files in changeset.
OLMIS-2349 create message file for stock card summaries

  1. … 3 more files in changeset.
OLMIS-2349 create message file for add products modal

  1. … 1 more file in changeset.
Since this state is the root state of stockmangement, we do need an `ui-view` markup at here.

Since this state is the root state of stockmangement, we do need an `ui-view` markup at here.

We create a tech debt issue for this. Will be implemented in ui-components soon.

We create a tech debt issue for this. Will be implemented in ui-components soon.

This should be changed over to the OpenLMIS-UI Modal Service

This should be changed over to the OpenLMIS-UI Modal Service

this file should be named `reason-form-modal.factory.js` or `reason-form.modal.js`

this file should be named `reason-form-modal.factory.js` or `reason-form.modal.js`

Please don't make the table fullwidth....

Please don't make the table fullwidth....

This is the default pagination size? If so, please pull that constant... otherwise, please make this a configurable constant using the `@@` syntax

This is the default pagination size? If so, please pull that constant... otherwise, please make this a configurable constant using the `@@` syntax

This seems to be old code.... I can't find where $stateParams.program would be directly set IMHO, you might want to wrap this program definition and open an alert modal if the programId doesn't ex...

This seems to be old code.... I can't find where $stateParams.program would be directly set

IMHO, you might want to wrap this program definition and open an alert modal if the programId doesn't exist...

Note: We don't make tables full width, they are as big as they need to be (fluid width) – this is a detail that was impossible to communicate through the design process (which we should work on)

Note: We don't make tables full width, they are as big as they need to be (fluid width) – this is a detail that was impossible to communicate through the design process (which we should work on)

PS: You don't need to add the form-control class (its implicitly applied with CSS)

PS: You don't need to add the form-control class (its implicitly applied with CSS)

Ideally this would have been a reusable angular component, which would look something like this: <openlmis-progress-bar percentage="vm.getPercentage()" message="Some message" />

Ideally this would have been a reusable angular component, which would look something like this:

  <openlmis-progress-bar percentage="vm.getPercentage()" message="Some message" />
Just FYI - you don't need the outside button-group div, this would look the same     <button class="primary" ng-click="">{{'button.submit' | message}}</button>

Just FYI - you don't need the outside button-group div, this would look the same

 
  <button class="primary" ng-click="">{{'button.submit' | message}}</button>
You should use an interpolated sting for this – it is implemented in our message filter implementation see: http://build.openlmis.org/job/OpenLMIS-reference-ui/lastSuccessfulBuild/artifact/build/do...

You should use an interpolated sting for this – it is implemented in our message filter implementation see:
http://build.openlmis.org/job/OpenLMIS-reference-ui/lastSuccessfulBuild/artifact/build/docs/index.html#/api/openlmis-i18n.filter:message

These unit tests are helpful to look at:
https://github.com/OpenLMIS/openlmis-ui-components/blob/master/src/openlmis-i18n/message.service.spec.js#L29-L30

The reason is that some languages might change the grammar entirely, so we should pass the dynamic value into the message string (ie vm.facility.name)

This is a general note — I've been meaning to drop support for underscore.js within our UI, since we don't use it — except stock management code

This is a general note — I've been meaning to drop support for underscore.js within our UI, since we don't use it — except stock management code

This message files should be separated into the specific module/directories that they are actually being used. The idea is to make string specific to a module and not reuse strings See OLMIS-1609 ...

This message files should be separated into the specific module/directories that they are actually being used. The idea is to make string specific to a module and not reuse strings

See OLMIS-1609 for the new instructions about how to name strings