openlmis-stockmanagement-ui

package.json

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 23 Sep 21
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Sep 2021
11:18 am

hdsldv

Tuesday 28 Sep 2021
11:21 am

Paweł Muchowski

11:00 am

hdsldv

done

done

10:39 am

Paweł Muchowski

You should change the type to button and rename the onSubmit method

You should change the type to button and rename the onSubmit method

10:15 am

hdsldv

removed form along with adapter

removed form along with adapter

10:15 am

hdsldv

done

done

10:15 am

hdsldv

done

done

10:04 am

hdsldv

done

done

8:31 am

Paweł Muchowski

when you will have all the remaining properties in the props variable you can pass all of them to the component like that <select {...props}>

when you will have all the remaining properties in the props variable you can pass all of them to the component like that 

<select {...props}>
8:29 am

Paweł Muchowski

you can change the props to ({ options, ...props }) if you do it like that it will take the options from properties and save the remaining properties in the props variable

you can change the props to 

({ options, ...props })

if you do it like that it will take the options from properties and save the remaining properties in the props variable

8:25 am

Paweł Muchowski

I think instead of adding an adapter you can add a separate component named SelectField and use form Field there

I think instead of adding an adapter you can add a separate component named SelectField and use form Field there

8:11 am

Paweł Muchowski

select don't need name and you also should remove the required property

select don't need name and you also should remove the required property

Monday 27 Sep 2021
10:06 pm

hdsldv

done, added adapter for use with react form

done, added adapter for use with react form

Sunday 26 Sep 2021
4:05 pm

Paweł Muchowski

I'm not sure if we need a form here, it's just one select. I think you can have a select and disable the "Make ..." button until value is selected and then do the redirect on button click.

I'm not sure if we need a form here, it's just one select. I think you can have a select and disable the "Make ..." button until value is selected and then do the redirect on button click.

4:02 pm

Paweł Muchowski

This component should be just the select, not the form Field with the select, because we might want to use the select outside of the form

This component should be just the select, not the form Field with the select, because we might want to use the select outside of the form

Thursday 23 Sep 2021
3:55 pm

hdsldv

removed

removed

3:52 pm

hdsldv <88383112+hdsldv@users.noreply.github.com>

OLMIS-7379 Remove redundant dependencies from package.json

Options
    • -7
    • +1
    /package.json
3:50 pm

hdsldv

added

added

3:50 pm

hdsldv

removed as not needed anymore

removed as not needed anymore

3:50 pm

hdsldv

removed

removed

3:50 pm

hdsldv

done

done

3:49 pm

hdsldv

done

done

3:49 pm

hdsldv

done

done

Wednesday 22 Sep 2021
7:55 am

hdsldv <88383112+hdsldv@users.noreply.github.com>

OLMIS-7379 Add react router

Options
    • -2
    • +5
    /package.json
  2. … 8 more files in changeset.
Monday 20 Sep 2021
8:50 am

Paweł Muchowski

you don't have to add component in the name of the file or the component, I think ProgramSelect should be fine

you don't have to add component in the name of the file or the component, I think ProgramSelect should be fine

8:37 am

Paweł Muchowski

Can you add a new component for the select, it can be useful in other places too.

Can you add a new component for the select, it can be useful in other places too.

8:35 am

Paweł Muchowski

Is this used to get the saved form values?

Is this used to get the saved form values?

8:21 am

Paweł Muchowski

I don't think this div is needed here

I don't think this div is needed here

8:19 am

Paweł Muchowski

I don't think we should add any classes here, add it in the main component (PhysicalInventoryApp)

I don't think we should add any classes here, add it in the main component (PhysicalInventoryApp)

8:15 am

Paweł Muchowski

add final-form here

add final-form here