openlmis-stockmanagement

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
changed version to 5.0.2-SNAPSHOT

patch release 5.0.1

OLMIS-6630: Fix compareTo method and add tests for compareTo contracts. (#18)

* OLMIS-6630: Fix compareTo method and add tests for compareTo contracts.

* OLMIS-6630: split test into 4 separate

* OLMIS-6630: refactored test to be more descriptive

removed delta and signum from asserts

Merge branch 'master' into OLMIS-6630

OLMIS-6630: refactored test to be more descriptive

removed delta and signum from asserts

Bumped version to 5.0.1-SNAPSHOT

OLMIS-6614 Added missing test

Release 5.0.0

OLMIS-6630: split test into 4 separate

OLMIS-6630: Fix compareTo method and add tests for compareTo contracts.

Changed service version back to SNAPSHOT

OLMIS-6623: Release stockmanagement service 5.0.0-RC2

OLMIS-6614: Replaced multiple calls to reference data by one call to the `GET /api/orderableFulfills` endpoint

OLMIS-6614: Added missing javadoc param

OLMIS-6614: Fixed pmd errors

OLMIS-6614: Added changelog & fixed checkstyle/test errors

Merged with master

OLMIS-6614: Fixed compilation errors

OLMIS-6614: Fixed unit tests and add additional profiler

OLMIS-6614: Replaced multiple calls to referencedata by a one call

OLMIS-6590: Updated test comment

OLMIS-6590: Added more descriptive comment

Ah, that makes sense now (from this comment, not from the comments in the test though)

Ah, that makes sense now (from this comment, not from the comments in the test though)

We are submitting physical inventory for day 1 with quantity 50, current SoH for day 1 is 10, after recalculation, it should be changed to 50. From those 2 numbers, we can calculate that the differ...

We are submitting physical inventory for day 1 with quantity 50, current SoH for day 1 is 10, after recalculation, it should be changed to 50. From those 2 numbers, we can calculate that the difference between old SoH and submitted physical inventory is +40. Then we need to update all following days with the difference calculated, so previously day 2 had SoH 20, now it is 60, day 3 had SoH 30, now it has 70.

OLMIS-6590: Added comments to describe the quantities

TBH, I'm lost on why 50, 60 and 70 are expected here. Maybe it would be worth to extract those numbers to final variables and name them appropriately for clarity, or at the very least add some comm...

TBH, I'm lost on why 50, 60 and 70 are expected here. Maybe it would be worth to extract those numbers to final variables and name them appropriately for clarity, or at the very least add some comments

OLMIS-6590: Fixed changelog entry