requisition-status-messages

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6153: added translation for requisition statuses

  1. … 6 more files in changeset.
OLMIS-6153: added translation for requisition statuses

  1. … 6 more files in changeset.
OLMIS-6153: added translation for requisition statuses

  1. … 6 more files in changeset.
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts

    • -0
    • +11
    ./status-messages.controller.spec.js
  1. … 30 more files in changeset.
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

  1. … 58 more files in changeset.
OLMIS-4388: ESlint tech debt fixes - part 4
OLMIS-4388: ESlint tech debt fixes - part 4
OLMIS-4388: ESlint tech debt fixes - part 4

    • -1
    • +1
    ./status-messages-history-modal.service.js
  1. … 18 more files in changeset.
Revert "OLMIS-4388: ESlint tech debt fixes - part 4"

This reverts commit e77cfbded873d60f7bfcd7ee4e0aad144b9becf2.

    • -1
    • +1
    ./status-messages-history-modal.service.js
  1. … 17 more files in changeset.
OLMIS-4388: ESlint tech debt fixes - part 4

    • -1
    • +1
    ./status-messages-history-modal.service.js
  1. … 17 more files in changeset.
This commit didn't change this code.

This commit didn't change this code.

Yeah, it sucks that FishEye expressed the diff this way. You can see the code changes better on the GitHub commit. (https://github.com/OpenLMIS/openlmis-requisition-ui/commit/020f39dc0a1c1583ded3c2...

Yeah, it sucks that FishEye expressed the diff this way. You can see the code changes better on the GitHub commit. (https://github.com/OpenLMIS/openlmis-requisition-ui/commit/020f39dc0a1c1583ded3c204b589bf9f6a2c6d3e)

Chongsun Ahn This review is hard to read because .... Fish Eye didn't meaningfully highlight your changes.... I agree with Nikodem Graczewski that the code in this file doesn't really help anythin...

Chongsun Ahn This review is hard to read because .... Fish Eye didn't meaningfully highlight your changes....

I agree with Nikodem Graczewski that the code in this file doesn't really help anything.... and I think this code might be more easily expressed another way.... but that isn't really the point of this ticket....

I'm totally fine with these changes — and I don't think there is a reason to resolve the issues Nikodem Graczewski raised in this ticket (even though, yes, its tech debt)

Agreed, but not part of what this review actually changed — also ugh fish eye

Agreed, but not part of what this review actually changed — also ugh fish eye

Yea.... this isn't part of the review though

Yea.... this isn't part of the review though

This would probably make more sense in the Requisition/StatusMessage class.

This would probably make more sense in the Requisition/StatusMessage class.

How does this adds a comment?

How does this adds a comment?

This should be set in @onInit method.

This should be set in @onInit method.

OLMIS-3527 Change criteria for if a comment can be added or edited
OLMIS-3527 Change criteria for if a comment can be added or edited