requisition-losses-and-adjustments

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts

    • -0
    • +1
    ./losses-and-adjustments.controller.spec.js
  1. … 30 more files in changeset.
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

    • -8
    • +13
    ./losses-and-adjustments.controller.spec.js
  1. … 58 more files in changeset.
Please, take a closed look at this file.

Please, take a closed look at this file.

OLMIS-4388: ESlint tech debt fixes - part 3
OLMIS-4388: ESlint tech debt fixes - part 3
OLMIS-4388: ESlint tech debt fixes - part 3

  1. … 14 more files in changeset.
Thanks, I created OLMIS-3436

Thanks, I created OLMIS-3436

Looks fine enough... see note about changing API - we could make a techDebt ticket for that (its insane)

Looks fine enough... see note about changing API - we could make a techDebt ticket for that (its insane)

This is an insane list of arguments – is it worth changing the API so this is a configuration object that gets passed? it might be a little simpler to read

This is an insane list of arguments – is it worth changing the API so this is a configuration object that gets passed? it might be a little simpler to read

OLMIS-3409 Filter available reasons by selected adjustments
OLMIS-3409 Filter available reasons by selected adjustments
OLMIS-3409 Filter available reasons by selected adjustments

This adds a filter to the adjustments modal that makes it only

display reasons in the dropdown that are not already used/added.

    • -1
    • +18
    ./losses-and-adjustments.controller.js
    • -2
    • +6
    ./losses-and-adjustments.controller.spec.js
LGTM

LGTM

OLMIS-3246: move filter logic to factory

    • -3
    • +1
    ./losses-and-adjustments.controller.js
    • -16
    • +10
    ./losses-and-adjustments.controller.spec.js
  1. … 3 more files in changeset.
Controllers should only be concerned about linking data together, not manipulating it. Please make this change in a service or a factory.

Controllers should only be concerned about linking data together, not manipulating it.

Please make this change in a service or a factory.

OLMIS-3246: filter and show only not hidden reasons in requisition view
OLMIS-3246: filter and show only not hidden reasons in requisition view