requisition-constants

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6153: added translation for requisition statuses

    • -12
    • +14
    ./requisition-status.constant.js
    • -28
    • +33
    ./requisition-status.constant.spec.js
  1. … 4 more files in changeset.
OLMIS-6153: added translation for requisition statuses

    • -12
    • +14
    ./requisition-status.constant.js
    • -28
    • +33
    ./requisition-status.constant.spec.js
  1. … 4 more files in changeset.
OLMIS-6153: added translation for requisition statuses

    • -12
    • +14
    ./requisition-status.constant.js
    • -28
    • +33
    ./requisition-status.constant.spec.js
  1. … 4 more files in changeset.
OLMIS-4968 - make packsToShip Rnr column to be visible on approval page or on all pages based on the new admin template option
OLMIS-4968 - make packsToShip Rnr column to be visible on approval page or on all pages based on the new admin template option
OLMIS-4968 Make packsToShip column to be seen only on Rnr approval screen or on all Rnr screens bases on admin template configuration

  1. … 5 more files in changeset.
OLMIS-5395: enabled max stock quantity and calculated order quantity columns
OLMIS-5395: enabled max stock quantity and calculated order quantity columns
OLMIS-5395: Fixed eslint issues and outdated test

  1. … 2 more files in changeset.
OLMIS-5395: enabled max stock quantity and calc order quantity columns

    • -10
    • +0
    ./template-columns.constant.spec.js
  1. … 10 more files in changeset.
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

  1. … 57 more files in changeset.
Still doesn't seem correct or I'm missing something. Where are we setting the value for avg consumption column? I only see setting value for total consumed quantity. Only the returned value seems t...

Still doesn't seem correct or I'm missing something. Where are we setting the value for avg consumption column? I only see setting value for total consumed quantity. Only the returned value seems to be the average consumption. Let me know if I'm wrong.

+1

+1

There should be other tests that invoke the constructor when testing the actual logic. We should not test constructors ourselves - this makes no sense and doesn't test anything.

There should be other tests that invoke the constructor when testing the actual logic. We should not test constructors ourselves - this makes no sense and doesn't test anything.

quite possible because of sonar?

quite possible because of sonar?

Why are we testing a constructor..?

Why are we testing a constructor..?

probably makes sense to mark them final

probably makes sense to mark them final

doesn't seem correct

doesn't seem correct

Please, take a closed look at this file.

Please, take a closed look at this file.