requisition-batch-approval

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Changelog reminder.

Changelog reminder.

OLMIS-6416 Modified caching facilities and processing periods on get and added VersionObjectReferenceDataBuilder...
OLMIS-6416 Modified caching facilities and processing periods on get and added VersionObjectReferenceDataBuilder...
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
Fixed in FEOLMIS-3291.

Fixed in FEOLMIS-3291.

Yep, Sonar would fail if it wasn't. https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/biggrin.gif

Yep, Sonar would fail if it wasn't.

Could you fix the typo in 'Arry'?

Could you fix the typo in 'Arry'?

Is this covered now?

Is this covered now?

Remove this file.

Remove this file.

Please, take a closed look at this file.

Please, take a closed look at this file.

Please, take a closed look at this file.

Please, take a closed look at this file.

Please, take a closer look at this file. https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

Please, take a closer look at this file.

OLMIS-4388: ESlint tech debt fixes - part 2
OLMIS-4388: ESlint tech debt fixes - part 2
Add missing module name.

Add missing module name.

Allows getting?

Allows getting?

remove this

remove this

So...... this line is replacing placeholders in openlmis.js with env variables and saving result to some temp file. The problem is that if envsubst encounters any ${SOMETHING} and there is no SOMET...

So...... this line is replacing placeholders in openlmis.js with env variables and saving result to some temp file. The problem is that if envsubst encounters any ${SOMETHING} and there is no SOMETHING variable exported empty string will be placed there, unfortunately there is one place in some library that uses "${". The only way to avoid this is to pass every env variable name that we want to replace to envsubst so I'm passing those using "`printf ${%s}.......

Yes you are right so we can stay with current approach https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

Yes you are right so we can stay with current approach