requisition-approval-list.html

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6125: fixed issue with showing message

OLMIS-6125: Fixed html tag

OLMIS-6125: Display message in submitted/authorized column on approve screen for partner requisitions
OLMIS-6125: Display message in submitted/authorized column on approve screen for partner requisitions
OLMIS-6125: Display message in submitted/authorized column on approve screen for partner requisitions

  1. … 2 more files in changeset.
see objectives

see objectives

changelog?

changelog?

OLMIS-5578: Adjusted sort component position on batch approval screen
OLMIS-5578: Adjusted sort component position on batch approval screen
OLMIS-5578: Adjusted sort component position on batch approval screen

added

added

how about adding info about new column on approve page?

how about adding info about new column on approve page?

changed

changed

Should both words be uppercase? In other columns only the first word is capitalized i.e. "Start date" or "Date submitted".

Should both words be uppercase? In other columns only the first word is capitalized i.e. "Start date" or "Date submitted".

OLMIS-5226: Added sort component on the Approve screen in Requisitions
OLMIS-5226: Added sort component on the Approve screen in Requisitions
OLMIS-5226: Added sort component on the Approve screen in Requisitions

  1. … 6 more files in changeset.
Add missing module name.

Add missing module name.

Allows getting?

Allows getting?

remove this

remove this

So...... this line is replacing placeholders in openlmis.js with env variables and saving result to some temp file. The problem is that if envsubst encounters any ${SOMETHING} and there is no SOMET...

So...... this line is replacing placeholders in openlmis.js with env variables and saving result to some temp file. The problem is that if envsubst encounters any ${SOMETHING} and there is no SOMETHING variable exported empty string will be placed there, unfortunately there is one place in some library that uses "${". The only way to avoid this is to pass every env variable name that we want to replace to envsubst so I'm passing those using "`printf ${%s}.......

Yes you are right so we can stay with current approach https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

Yes you are right so we can stay with current approach

Then we would have a lot of code duplication

Then we would have a lot of code duplication

A lot of ng-if here. Maybe it would be better to have two files and select correct based on flag? Not sure if this is a easy task in angular/js

A lot of ng-if here. Maybe it would be better to have two files and select correct based on flag? Not sure if this is a easy task in angular/js

http://mrwgifs.com/wp-content/uploads/2013/10/The-Big-Lebowski-WTF-Expression-While-Checking-Things-Out.gif